Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove occ db:convet-type which doesn't work with migrations #28744

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

Description

Removes this broken command. See ticket why.

If we want this feature back, let's reimplement it as a separate app. But from the looks, it seems to be technically impossible due to the unpredictable nature of migrations implemented by third party apps.

Related Issue

Closes #27075

Motivation and Context

To avoid having people stumble upon this broken feature.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Once merge, documentation should be updated (delete the matching sections)

@PVince81 PVince81 added this to the development milestone Aug 18, 2017
@PVince81 PVince81 requested a review from DeepDiver1975 August 18, 2017 13:48
@PVince81 PVince81 self-assigned this Aug 18, 2017
@PVince81
Copy link
Contributor Author

@pmaier1 FYI

@PVince81
Copy link
Contributor Author

Talked with @DeepDiver1975 who wants to give this another chance

@PVince81 PVince81 closed this Aug 29, 2017
@PVince81 PVince81 deleted the remove-broken-convert-type branch August 29, 2017 17:38
@felixboehm felixboehm removed this from the triage milestone Apr 10, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

occ db:convert-type doesn't work with migration
3 participants