Bigint update case #28590

VicDeo · 2017-08-04T19:44:14Z

Description

It appeared that old-fashioned MDB2 schema ignores changing length and doesn't migrate it to bigint.
Due to issue with migrations on postgres minor supported version for apps was increased

Related Issue

#26901

How Has This Been Tested?

Manual update from 10.0.2

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

VicDeo · 2017-08-04T22:52:23Z

WTF is that????
https://github.com/owncloud/core/blob/master/apps/files_sharing/appinfo/app.php#L64

VicDeo · 2017-08-04T23:30:40Z

A new bunch of surprises. Files_sharing is installed before files and contains another gift inside....

PVince81 · 2017-08-07T08:25:37Z

apps/federatedfilesharing/appinfo/Migrations/Version20170804201125.php

+			\OC::$server->getConfig(),
+			\OC::$server->getDatabaseConnection()->getDatabasePlatform()
+		);
+		$schemaReader->loadSchemaFromFile(__DIR__ . '/../database.xml', $schema);


just port the table to a migration ?

@PVince81 done

PVince81

👍 looks good

@VicDeo did you test installing, upgrading this time ?
Diffed the schema dumps to confirm that they are the same when using migrations ?

VicDeo · 2017-08-08T09:23:30Z

@PVince81 with Mysql only so far

VicDeo · 2017-08-08T15:09:10Z

Comparing 10.0.2 with this branch:

mysql> use o1002;
Database changed
mysql> describe oc_federated_reshares;
+-----------+---------+------+-----+---------+-------+
| Field     | Type    | Null | Key | Default | Extra |
+-----------+---------+------+-----+---------+-------+
| share_id  | int(11) | NO   | PRI | NULL    |       |
| remote_id | int(11) | NO   |     | NULL    |       |
+-----------+---------+------+-----+---------+-------+
2 rows in set (0.00 sec)

mysql> use biginttest;
Database changed
mysql> describe oc_federated_reshares;
+-----------+------------+------+-----+---------+-------+
| Field     | Type       | Null | Key | Default | Extra |
+-----------+------------+------+-----+---------+-------+
| share_id  | bigint(20) | NO   | PRI | NULL    |       |
| remote_id | bigint(20) | NO   |     | NULL    |       |
+-----------+------------+------+-----+---------+-------+
2 rows in set (0.00 sec)

mysql> use o1002;
Database changed
mysql> describe oc_share_external;
+-----------------+---------------+------+-----+---------+----------------+
| Field           | Type          | Null | Key | Default | Extra          |
+-----------------+---------------+------+-----+---------+----------------+
| id              | int(11)       | NO   | PRI | NULL    | auto_increment |
| remote          | varchar(512)  | NO   |     | NULL    |                |
| remote_id       | int(11)       | NO   |     | -1      |                |
| share_token     | varchar(64)   | NO   |     | NULL    |                |
| password        | varchar(64)   | YES  |     | NULL    |                |
| name            | varchar(64)   | NO   |     | NULL    |                |
| owner           | varchar(64)   | NO   |     | NULL    |                |
| user            | varchar(64)   | NO   | MUL | NULL    |                |
| mountpoint      | varchar(4000) | NO   |     | NULL    |                |
| mountpoint_hash | varchar(32)   | NO   |     | NULL    |                |
| accepted        | int(11)       | NO   |     | 0       |                |
+-----------------+---------------+------+-----+---------+----------------+
11 rows in set (0.00 sec)
mysql> use biginttest;
Database changed
mysql> describe oc_share_external;
+-----------------+---------------+------+-----+---------+----------------+
| Field           | Type          | Null | Key | Default | Extra          |
+-----------------+---------------+------+-----+---------+----------------+
| id              | bigint(20)    | NO   | PRI | NULL    | auto_increment |
| remote          | varchar(512)  | NO   |     | NULL    |                |
| remote_id       | bigint(20)    | NO   |     | -1      |                |
| share_token     | varchar(64)   | NO   |     | NULL    |                |
| password        | varchar(64)   | YES  |     | NULL    |                |
| name            | varchar(64)   | NO   |     | NULL    |                |
| owner           | varchar(64)   | NO   |     | NULL    |                |
| user            | varchar(64)   | NO   | MUL | NULL    |                |
| mountpoint      | varchar(4000) | NO   |     | NULL    |                |
| mountpoint_hash | varchar(32)   | NO   |     | NULL    |                |
| accepted        | int(11)       | NO   |     | 0       |                |
+-----------------+---------------+------+-----+---------+----------------+
11 rows in set (0.00 sec)


mysql> use o1002;
Database changed
mysql> describe oc_files_trash;
+-----------+--------------+------+-----+---------+----------------+
| Field     | Type         | Null | Key | Default | Extra          |
+-----------+--------------+------+-----+---------+----------------+
| auto_id   | int(11)      | NO   | PRI | NULL    | auto_increment |
| id        | varchar(250) | NO   | MUL |         |                |
| user      | varchar(64)  | NO   | MUL |         |                |
| timestamp | varchar(12)  | NO   | MUL |         |                |
| location  | varchar(512) | NO   |     |         |                |
| type      | varchar(4)   | YES  |     | NULL    |                |
| mime      | varchar(255) | YES  |     | NULL    |                |
+-----------+--------------+------+-----+---------+----------------+
7 rows in set (0.00 sec)

mysql> use biginttest;
Database changed
mysql> describe oc_files_trash;
+-----------+--------------+------+-----+---------+----------------+
| Field     | Type         | Null | Key | Default | Extra          |
+-----------+--------------+------+-----+---------+----------------+
| auto_id   | int(11)      | NO   | PRI | NULL    | auto_increment |
| id        | varchar(250) | NO   | MUL |         |                |
| user      | varchar(64)  | NO   | MUL |         |                |
| timestamp | varchar(12)  | NO   | MUL |         |                |
| location  | varchar(512) | NO   |     |         |                |
| type      | varchar(4)   | YES  |     | NULL    |                |
| mime      | varchar(255) | YES  |     | NULL    |                |
+-----------+--------------+------+-----+---------+----------------+
7 rows in set (0.00 sec)

PVince81 · 2017-08-08T15:10:38Z

@VicDeo better use "mysqldump" instead as it contains more details and also contains the indices.

VicDeo · 2017-08-08T15:19:43Z

mysql> use o1002;
Database changed
 show create table oc_federated_reshares;
| oc_federated_reshares | CREATE TABLE `oc_federated_reshares` (
  `share_id` int(11) NOT NULL,
  `remote_id` int(11) NOT NULL COMMENT 'share ID at the remote server',
  UNIQUE KEY `share_id_index` (`share_id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin |

mysql> use biginttest;
Database changed
mysql> show create table oc_federated_reshares;
| oc_federated_reshares | CREATE TABLE `oc_federated_reshares` (
  `share_id` bigint(20) NOT NULL,
  `remote_id` bigint(20) NOT NULL COMMENT 'share ID at the remote server',
  UNIQUE KEY `share_id_index` (`share_id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin |


mysql> use o1002;
Database changed
mysql> show create table oc_share_external;        
| oc_share_external | CREATE TABLE `oc_share_external` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `remote` varchar(512) COLLATE utf8_bin NOT NULL COMMENT 'Url of the remove owncloud instance',
  `remote_id` int(11) NOT NULL DEFAULT '-1',
  `share_token` varchar(64) COLLATE utf8_bin NOT NULL COMMENT 'Public share token',
  `password` varchar(64) COLLATE utf8_bin DEFAULT NULL COMMENT 'Optional password for the public share',
  `name` varchar(64) COLLATE utf8_bin NOT NULL COMMENT 'Original name on the remote server',
  `owner` varchar(64) COLLATE utf8_bin NOT NULL COMMENT 'User that owns the public share on the remote server',
  `user` varchar(64) COLLATE utf8_bin NOT NULL COMMENT 'Local user which added the external share',
  `mountpoint` varchar(4000) COLLATE utf8_bin NOT NULL COMMENT 'Full path where the share is mounted',
  `mountpoint_hash` varchar(32) COLLATE utf8_bin NOT NULL COMMENT 'md5 hash of the mountpoint',
  `accepted` int(11) NOT NULL DEFAULT '0',
  PRIMARY KEY (`id`),
  UNIQUE KEY `sh_external_mp` (`user`,`mountpoint_hash`),
  KEY `sh_external_user` (`user`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin |

mysql> use biginttest;
Database changed
mysql> show create table oc_share_external;
oc_share_external | CREATE TABLE `oc_share_external` (
  `id` bigint(20) NOT NULL AUTO_INCREMENT,
  `remote` varchar(512) COLLATE utf8_bin NOT NULL COMMENT 'Url of the remote owncloud instance',
  `remote_id` bigint(20) NOT NULL DEFAULT '-1',
  `share_token` varchar(64) COLLATE utf8_bin NOT NULL COMMENT 'Public share token',
  `password` varchar(64) COLLATE utf8_bin DEFAULT NULL COMMENT 'Optional password for the public share',
  `name` varchar(64) COLLATE utf8_bin NOT NULL COMMENT 'Original name on the remote server',
  `owner` varchar(64) COLLATE utf8_bin NOT NULL COMMENT 'User that owns the public share on the remote server',
  `user` varchar(64) COLLATE utf8_bin NOT NULL COMMENT 'Local user which added the external share',
  `mountpoint` varchar(4000) COLLATE utf8_bin NOT NULL COMMENT 'Full path where the share is mounted',
  `mountpoint_hash` varchar(32) COLLATE utf8_bin NOT NULL COMMENT 'md5 hash of the mountpoint',
  `accepted` int(11) NOT NULL DEFAULT '0',
  PRIMARY KEY (`id`),
  UNIQUE KEY `sh_external_mp` (`user`,`mountpoint_hash`),
  KEY `sh_external_user` (`user`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin |

mysql> use o1002;
Database changed
mysql> show create table oc_files_trash;
| oc_files_trash | CREATE TABLE `oc_files_trash` (
  `auto_id` int(11) NOT NULL AUTO_INCREMENT,
  `id` varchar(250) COLLATE utf8_bin NOT NULL DEFAULT '',
  `user` varchar(64) COLLATE utf8_bin NOT NULL DEFAULT '',
  `timestamp` varchar(12) COLLATE utf8_bin NOT NULL DEFAULT '',
  `location` varchar(512) COLLATE utf8_bin NOT NULL DEFAULT '',
  `type` varchar(4) COLLATE utf8_bin DEFAULT NULL,
  `mime` varchar(255) COLLATE utf8_bin DEFAULT NULL,
  PRIMARY KEY (`auto_id`),
  KEY `id_index` (`id`),
  KEY `timestamp_index` (`timestamp`),
  KEY `user_index` (`user`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin |

mysql> use biginttest;
Database changed
mysql> show create table oc_files_trash;
| oc_files_trash | CREATE TABLE `oc_files_trash` (
  `auto_id` bigint(20) NOT NULL AUTO_INCREMENT,
  `id` varchar(250) COLLATE utf8_bin NOT NULL DEFAULT '',
  `user` varchar(64) COLLATE utf8_bin NOT NULL DEFAULT '',
  `timestamp` varchar(12) COLLATE utf8_bin NOT NULL DEFAULT '',
  `location` varchar(512) COLLATE utf8_bin NOT NULL DEFAULT '',
  `type` varchar(4) COLLATE utf8_bin DEFAULT NULL,
  `mime` varchar(255) COLLATE utf8_bin DEFAULT NULL,
  PRIMARY KEY (`auto_id`),
  KEY `id_index` (`id`),
  KEY `timestamp_index` (`timestamp`),
  KEY `user_index` (`user`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin |

VicDeo · 2017-08-08T22:44:38Z

Tests are passed. Merging.

VicDeo · 2017-08-09T15:11:29Z

Stable10: #28581

lock · 2019-08-02T22:02:02Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

VicDeo added the 2 - Developing label Aug 4, 2017

VicDeo added this to the development milestone Aug 4, 2017

VicDeo added 3 - To Review and removed 2 - Developing labels Aug 4, 2017

VicDeo mentioned this pull request Aug 4, 2017

fileid of oc_filecache in danger of hitting max value #26901

Closed

VicDeo force-pushed the bigint-update-case branch from 1fe80dd to 15bea4e Compare August 5, 2017 00:04

PVince81 reviewed Aug 7, 2017

View reviewed changes

PVince81 assigned VicDeo Aug 7, 2017

VicDeo added 10 commits August 7, 2017 18:03

Update federatedreshares to bigint

54f5a31

Bump federatedfilesharing to 0.3.1 to trigger migrations

c5ad2c8

Update files_sharing to bigint

5940edc

Bump files_sharing to 0.10.1 to trigger migrations

8ca865e

Update files_trashbin to bigint

5eca9c7

Bump files_trashbin to 0.9.1 to trigger migrations

da02bdf

Bump depends and core version

dc3dfeb

Update core tables to bigint

0c2d9a0

Defuse the bombs

b438c6c

Session is null during installation

b7581b9

VicDeo force-pushed the bigint-update-case branch 3 times, most recently from baa91a3 to 42cc0ea Compare August 7, 2017 16:26

Port tables to migration

fb132dc

VicDeo force-pushed the bigint-update-case branch from 42cc0ea to fb132dc Compare August 7, 2017 18:35

PVince81 approved these changes Aug 8, 2017

View reviewed changes

Update defaults

0c0b61f

VicDeo merged commit 277496e into master Aug 8, 2017

VicDeo deleted the bigint-update-case branch August 8, 2017 22:44

VicDeo mentioned this pull request Aug 9, 2017

[Stable10] use bigint for fileid #28581

Merged

ownclouders added the status/STALE label Dec 20, 2017

lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bigint update case #28590

Bigint update case #28590

VicDeo commented Aug 4, 2017 •

edited

Loading

VicDeo commented Aug 4, 2017

VicDeo commented Aug 4, 2017

PVince81 Aug 7, 2017

VicDeo Aug 7, 2017

PVince81 left a comment

VicDeo commented Aug 8, 2017

VicDeo commented Aug 8, 2017 •

edited

Loading

PVince81 commented Aug 8, 2017

VicDeo commented Aug 8, 2017 •

edited

Loading

VicDeo commented Aug 8, 2017

VicDeo commented Aug 9, 2017

lock bot commented Aug 2, 2019

Bigint update case #28590

Bigint update case #28590

Conversation

VicDeo commented Aug 4, 2017 • edited Loading

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

VicDeo commented Aug 4, 2017

VicDeo commented Aug 4, 2017

PVince81 Aug 7, 2017

Choose a reason for hiding this comment

VicDeo Aug 7, 2017

Choose a reason for hiding this comment

PVince81 left a comment

Choose a reason for hiding this comment

VicDeo commented Aug 8, 2017

VicDeo commented Aug 8, 2017 • edited Loading

PVince81 commented Aug 8, 2017

VicDeo commented Aug 8, 2017 • edited Loading

VicDeo commented Aug 8, 2017

VicDeo commented Aug 9, 2017

lock bot commented Aug 2, 2019

VicDeo commented Aug 4, 2017 •

edited

Loading

VicDeo commented Aug 8, 2017 •

edited

Loading

VicDeo commented Aug 8, 2017 •

edited

Loading