Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app enable of not existing app #28239

Merged
merged 5 commits into from
Jul 6, 2017
Merged

Fix app enable of not existing app #28239

merged 5 commits into from
Jul 6, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jun 27, 2017 •
edited
Loading

Description

Actually fixes to issues:

  • one related to enabling an app which is removed from the system (rm -rf apps/$APPNAME)
  • allow uninstall of the enterprise key app

Related Issue

owncloud/market#94

How Has This Been Tested?

  • install an app

  • enable it

  • remove the folder

  • call ./occ app:enable

  • EXPECTATION it shall not break on php7

  • install enterprise key app

  • try to uninstall it

  • EXPECTATION: one can uninstall it

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.1 milestone Jun 27, 2017
PVince81
PVince81 reviewed Jul 4, 2017
View reviewed changes
lib/public/App/IAppManager.php
* @return mixed
* @since 10.0
*/
public function installApp($package);
public function installApp($package, $skipMigrations = false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, need to get rid of this flag separately... it's unused now

@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2017

👍 otherwise if Jenkins is kind

@PVince81 PVince81 force-pushed the fix-app-enable-of-not-existing-app branch from 49ec84c to b529c31 Compare July 5, 2017 10:30
@PVince81
Copy link
Contributor

PVince81 commented Jul 5, 2017

rebased 🔨

@DeepDiver1975 DeepDiver1975 merged commit 7d6b25a into master Jul 6, 2017
@DeepDiver1975 DeepDiver1975 deleted the fix-app-enable-of-not-existing-app branch July 6, 2017 08:55
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 6, 2017
Merged
@DeepDiver1975 DeepDiver1975 modified the milestones: 10.1, development Oct 10, 2017
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 left review comments

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
10.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepDiver1975 @PVince81