[stable9.1] Add check for empty result in storage memcache #28229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fafe8f3 to
3d425db
Compare
tomneedham
approved these changes
Jul 20, 2017
|
@PVince81 Forward port? Seems safe. |
|
@tom go for it! |
|
I'll take care of the forward ports |
This was referenced Aug 1, 2017
|
let's only merge the stable9.1 once master and co have been merged too |
jvillafanez
reviewed
Aug 9, 2017
lib/private/Files/Cache/Storage.php
Outdated
| @@ -109,7 +109,7 @@ public static function getStorageById($storageId) { | |||
| self::$localCache = new CappedMemoryCache(); | |||
| } | |||
| $result = self::$localCache->get($storageId); | |||
| if ($result === null) { | |||
| if ($result === null || empty($result) || !isset($result['numeric_id'])) { | |||
|
@jvillafanez removed here now ffed517 |
jvillafanez
approved these changes
Aug 9, 2017
|
rebased |
ffed517 to
23d28a1
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was observed that sometimes the row data is empty which could be due to memcache returning empty arrays instead of null.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
@tomneedham