Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user backends to provide quotas #27661

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Conversation

PVince81
Copy link
Contributor

Description

Because user backends must not call set methods on IUser instances directly.

Related Issue

Required for fixing LDAP here owncloud/user_ldap#72

Motivation and Context

Because user backends must not call set methods on IUser instances directly.

How Has This Been Tested?

I just tested that regular user creation still works. There is no implementation out there yet to test properly.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 @jvillafanez review please

@PVince81 PVince81 added this to the 10.0 milestone Apr 18, 2017
* @return string
* @since 10.0
*/
public function getQuotaAddress($uid);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address?

@PVince81 PVince81 force-pushed the provide-quota-backend branch from 499bb92 to 71cc879 Compare April 18, 2017 13:34
@PVince81 PVince81 force-pushed the provide-quota-backend branch from 71cc879 to 70be9c0 Compare April 18, 2017 13:37
@PVince81
Copy link
Contributor Author

fixed the copy-paste replace fail

@DeepDiver1975 DeepDiver1975 merged commit 95831ac into master Apr 18, 2017
@DeepDiver1975 DeepDiver1975 deleted the provide-quota-backend branch April 18, 2017 15:00
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants