Created a config.php option to disable local mounts for files_externa… #26887

grischdian · 2016-12-29T16:24:31Z

…l. fixing #26653

Description

As in #26653 mentioned an option would be good to disable the 'local' option from files_external.
There is now a new Option for config.php called 'files_external_deny_local' which is set to false on default. Only if you set the option to true then the local Backend will not get registered.

Related Issue

#26653

Motivation and Context

If Sysadmin and oCadmin are not the same the Sysadmin may want to disable the local mount feature for security reasons.

How Has This Been Tested?

Compiled the actual master, installed php56 and apach24 on centos7 (Softwarecollection)
Tested without setting the option in config.php, tested with the option set to false and set to true.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
Line maybe to long - but have no shorter idea
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

…l. fixing #26653

CLAassistant · 2016-12-29T16:24:32Z

All committers have signed the CLA.

mention-bot · 2016-12-29T16:24:32Z

@grischdian, thanks for your PR! By analyzing the history of the files in this pull request, we identified @carlaschroder, @butonic, @PVince81 and @Xenopathic to be potential reviewers.

grischdian · 2017-01-07T08:44:42Z

@carlaschroder, @butonic, @PVince81 and @Xenopathic can someone explain why jenkins is failing? If I click on Details I got a "unable to connect" error

butonic · 2017-01-09T09:12:39Z

apps/files_external/lib/AppInfo/Application.php

-		];
+    ];
+
+      $this->denyLocalMounts = \OC::$server->getConfig()->getSystemValue('files_external_deny_local', 'false');


this will return the string 'false'. What you want is ..., false);

butonic · 2017-01-09T09:15:42Z

regarding jenkins:

sharing.Merging shares for recipient when shared from outside with group then user and recipient renames in between

Schlägt fehl seit 1 Build (Seit Fehlgeschlagen#1 )
Dauer: 8 Sekunden.
Stacktrace

Then as "user1" gets properties of folder "/merge-test-outside-groups-renamebeforesecondshare-renamed" with:

HTTP error: 404

PVince81 · 2017-01-09T10:30:03Z

@butonic that issue should disappear after rebasing onto master

PVince81

Great addition, thanks.

Please fix the indent and this should be good to go.

PVince81 · 2017-01-09T10:30:35Z

apps/files_external/lib/AppInfo/Application.php

+
+      if ($this->denyLocalMounts !== true) {
+        $backends[] = $container->query('OCA\Files_External\Lib\Backend\Local');
+      };


Please fix indentation, in ownCloud we use tabs, not spaces.

phisch · 2017-01-10T13:47:54Z

apps/files_external/lib/AppInfo/Application.php

@@ -93,6 +92,11 @@ public function getBackends() {
 			$container->query('OCA\Files_External\Lib\Backend\SMB_OC'),
 		];

+		$this->denyLocalMounts = \OC::$server->getConfig()->getSystemValue('files_external_deny_local', false);


It might be better to call it allowLocalMounts with a default of true to avoid multiple negations.

@PVince81 @butonic what do you prefer? In my opinion both sounds good ;)

@grischdian if you have time, please rename it to allowLocalMounts. I also prefer to avoid the double negative 😄

PVince81 · 2017-01-13T11:54:16Z

Setting back to "Developing" then

grischdian · 2017-01-17T13:24:19Z

will take care today

grischdian · 2017-01-20T11:18:12Z

I messed up my branch during changing from deny to allow - I close this PR - will open a new one. sorry

#26990) * fixed #26887 * fix identation

lock · 2019-08-04T02:01:34Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Created a config.php option to disable local mounts for files_externa…

837aec0

…l. fixing #26653

butonic reviewed Jan 9, 2017

View reviewed changes

changed string 'false' to real false.

3dfecb3

PVince81 added the 3 - To Review label Jan 9, 2017

PVince81 reviewed Jan 9, 2017

View reviewed changes

fixed indentation

6290bee

phisch reviewed Jan 10, 2017

View reviewed changes

PVince81 added 2 - Developing and removed 3 - To Review labels Jan 13, 2017

grischdian closed this Jan 20, 2017

grischdian mentioned this pull request Jan 20, 2017

Created a config.php option to disable local mounts for files_external #26990

Merged

8 tasks

PVince81 pushed a commit that referenced this pull request Jan 20, 2017

Created a config.php option to disable local mounts for files_external (

d4c5dcc

#26990) * fixed #26887 * fix identation

lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created a config.php option to disable local mounts for files_externa… #26887

Created a config.php option to disable local mounts for files_externa… #26887

grischdian commented Dec 29, 2016 •

edited by butonic

Loading

CLAassistant commented Dec 29, 2016 •

edited

Loading

mention-bot commented Dec 29, 2016

grischdian commented Jan 7, 2017 •

edited

Loading

butonic Jan 9, 2017

butonic commented Jan 9, 2017

PVince81 commented Jan 9, 2017

PVince81 left a comment

PVince81 Jan 9, 2017

phisch Jan 10, 2017 •

edited

Loading

grischdian Jan 11, 2017

PVince81 Jan 12, 2017

PVince81 commented Jan 13, 2017

grischdian commented Jan 17, 2017

grischdian commented Jan 20, 2017

lock bot commented Aug 4, 2019

Created a config.php option to disable local mounts for files_externa… #26887

Created a config.php option to disable local mounts for files_externa… #26887

Conversation

grischdian commented Dec 29, 2016 • edited by butonic Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

CLAassistant commented Dec 29, 2016 • edited Loading

mention-bot commented Dec 29, 2016

grischdian commented Jan 7, 2017 • edited Loading

butonic Jan 9, 2017

Choose a reason for hiding this comment

butonic commented Jan 9, 2017

PVince81 commented Jan 9, 2017

PVince81 left a comment

Choose a reason for hiding this comment

PVince81 Jan 9, 2017

Choose a reason for hiding this comment

phisch Jan 10, 2017 • edited Loading

Choose a reason for hiding this comment

grischdian Jan 11, 2017

Choose a reason for hiding this comment

PVince81 Jan 12, 2017

Choose a reason for hiding this comment

PVince81 commented Jan 13, 2017

grischdian commented Jan 17, 2017

grischdian commented Jan 20, 2017

lock bot commented Aug 4, 2019

grischdian commented Dec 29, 2016 •

edited by butonic

Loading

CLAassistant commented Dec 29, 2016 •

edited

Loading

grischdian commented Jan 7, 2017 •

edited

Loading

phisch Jan 10, 2017 •

edited

Loading