Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require to use at least desktop client 2.0 by default #26441

Merged
merged 3 commits into from
Oct 25, 2016

Conversation

DeepDiver1975
Copy link
Member

Description

asking for desktop client 2.0.0 as minimum by default

Motivation and Context

Force people to update in order to protect them from evil.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Oct 21, 2016
@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke to be a potential reviewer.

@PVince81
Copy link
Contributor

Jenkins hates you

@PVince81
Copy link
Contributor

Wow, we actually have tests for that:

15:17:26 1) OCA\DAV\Tests\unit\Connector\Sabre\BlockLegacyClientPluginTest::testBeforeHandlerException with data set #0 ('Mozilla/5.0 (1.5.0) mirall/1.5.0')
15:17:26 Expectation failed for method name is equal to <string:getSystemValue> when invoked 1 time(s)
15:17:26 Parameter 1 for invocation OCP\IConfig::getSystemValue('minimum.supported.desktop.version', '2.0.0') does not match expected value.
15:17:26 Failed asserting that two strings are equal.
15:17:26 --- Expected
15:17:26 +++ Actual
15:17:26 @@ @@
15:17:26 -'1.7.0'
15:17:26 +'2.0.0'

@LukasReschke
Copy link
Member

Wow, we actually have tests for that:

Of course. I have written that file 😉

@ghost
Copy link

ghost commented Oct 21, 2016

@PVince81
Copy link
Contributor

👍

@PVince81 PVince81 merged commit bf5bca5 into master Oct 25, 2016
@PVince81 PVince81 deleted the DeepDiver1975-patch-1 branch October 25, 2016 09:51
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants