Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned shares test and some requirements #25977

Merged
merged 2 commits into from
Sep 22, 2016

Conversation

SergioBertolinSG
Copy link
Contributor

@PVince81 it is failing getting a 500 instead of a 400 in the last step added.

@SergioBertolinSG SergioBertolinSG added this to the 9.2 milestone Aug 30, 2016
@mention-bot
Copy link

@SergioBertolinSG, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @rullzer and @PVince81 to be potential reviewers

@PVince81
Copy link
Contributor

Strange, am getting this:

--- FeatureContext has missing steps. Define them with these snippets:

    /**
     * @Given User :arg1 deletes file :arg2                                                                                                       
     */                                                                                                                                           
    public function userDeletesFile2($arg1, $arg2)                                                                                                
    {                                                                                                                                             
        throw new PendingException();                                                                                                             
    }     

@SergioBertolinSG
Copy link
Contributor Author

Let me check.

@SergioBertolinSG
Copy link
Contributor Author

SergioBertolinSG commented Aug 30, 2016

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

Okay, got it reproduced now, thanks!

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

Following the steps manually and at the end:

  % curl -X PROPFIND http://user1:test@localhost/owncloud/remote.php/webdav/sub
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>InvalidArgumentException</s:exception>
  <s:message>Jail rootPath is null</s:message>
</d:error>

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

@SergioBertolinSG something to add to the test, maybe as separate case: can user1 create a folder called "sub" ? (the internal logic seems to forbid this, even though the share should not be mounted any more)

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

Raised #26001 for the core issue. This will take a bit longer to fix...

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

oops, pushed on the wrong branch

@PVince81 PVince81 force-pushed the integration-tests-orphaned-shares branch from 34fce9f to 6177ac5 Compare September 1, 2016 10:29
@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

restored to the previous state.

@PVince81
Copy link
Contributor

PVince81 commented Sep 1, 2016

The test seems to pass with #26004

@PVince81 PVince81 force-pushed the integration-tests-orphaned-shares branch from 6177ac5 to e3f032f Compare September 7, 2016 20:28
@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2016

Rebased. The error should be gone now.

@PVince81 PVince81 force-pushed the integration-tests-orphaned-shares branch from e3f032f to 7443288 Compare September 16, 2016 10:10
@PVince81
Copy link
Contributor

Tests passed now, 👍

@SergioBertolinSG merge or did you want to add more stuff ?

@SergioBertolinSG
Copy link
Contributor Author

Merge yes.

@PVince81 PVince81 merged commit e1841a8 into master Sep 22, 2016
@PVince81 PVince81 deleted the integration-tests-orphaned-shares branch September 22, 2016 10:42
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants