Adapted integration tests for stable8.2 #25456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SergioBertolinSG, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @MorrisJobke and @rullzer to be potential reviewers |
|
Favorites scenarios 24 and 33 failing because |
3 tasks
|
provisioning-v1.feature:73, provisioning-v1.feature:141 and provisioning-v1.feature:258 fails because special characters are being rejected as invalid data. Bug which was fixed but never backported, this one was the fix #20961. |
|
provisioning-v1.feature:160 fails because subadmins can't get users before 9.0. Test removed as it is a new functionality in 9.0. |
|
Removed tests about enabling or disabling users, that functionality started in 9.1. |
|
Weird things which work in master and not in 8.2: This field in stable8.2 needs to be EDIT: OK understood the file_target confusion, setupFS in 8.2 was executed with every api call while in >9.0 it runs later. So the rename doesn't happens inmediately. |
|
Still failing cases at this point about sharing: Scenario: Check quota of owners parent directory of a shared file Scenario: Don't allow sharing of the root These couple are failing beacuse the final assertion is not matching, not sure if bug or test problem. |
I think this is an old bug that was fixed only in 9.1 and 9.0 and not backported. See #25138. You can remove that test. |
|
Scenario: Check quota of owners parent directory of a shared file |
…h doesn't work on 8.2
…requires to check the parent id instead of the actual share id
2e47b84 to
68ce236
Compare
|
Remaining: |
|
Looks like you also need to remove the test about special chars. Let's move that test to your other PR that fixes it. |
|
OK |
|
One last failure: |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed several contexts and scenarios which doesn't apply to 8.2.
Currently several tests fail. This is because some tests needs to be adjusting, but maybe other failures are showing bugs. I'll continue modifying the tests.