Properly deliver content-disposition when downloading in DAV from browser

[PVince81]

Steps to reproduce:

1. Upload a text file
2. For the text file, click on the "Download" link in the file row

Before: text file opened directly inline in browser
After: text file properly downloaded

Not sure why we have that $this->downloadAttachment property that is false sometimes so I left it and relied on the "downloadSecret" parameter.

Please review @owncloud/filesystem @rullzer @icewind1991

[mention-bot]

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @rullzer and @LukasReschke to be potential reviewers

[PVince81]

Hmmm that's really weird. Today I'm not able to reproduce the original issue and downloadAttachment is true. Must have been a weird side effect of some other testing.

[PVince81]

Okay, NOW I get it.

When setting "debug" => true in the config, it removes downloadAttachment.

Why ? @rullzer

[DeepDiver1975]

When setting "debug" => true in the config, it removes downloadAttachment.

as soon as debug is set to true we are loading sabre's browser plugin for easy debugging of dav - might be related ....

[PVince81]

Hmm not sure. Anyway I think this PR is obsolete.

[PVince81]

Another theory is that @rullzer maybe wanted to be able to see the download call in the network console and didn't know that in Chromium the network console will not reset/clear even for downloads.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.