-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added white download icons #23891
Added white download icons #23891
Conversation
eefe240
to
b060b2f
Compare
@@ -86,6 +86,10 @@ | |||
background-image: url('../img/actions/download.svg'); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cut this line break, so it belongs to the icon-download. Otherwise nice!
Nice! Looks like both are correctly minified/compressed, right? |
Well, i used the download icons black, revert the png and just added the fill parameter to the svg (like the upload-icon-white) Don't know if this could me more compressed :) @jancborchardt Line break removed. |
Yup, looks good! 👍 Just squash the commits into one (the first, with the good commit message). :) You can also in the future just amend your commits with:
|
Without git rebase? |
6fd37e9
to
408bdd6
Compare
Yeah, rebase is optional but different, just for updating it to current master. Amending and force pushing is for using the same commit in the current branch and overwriting it on the remote to not create two commits. |
Nice, I was always using a rebase HEAD to merge multiple commits. I only used ammend to correct an unpushed commit title. |
LGTM 👍 |
let get this merged? |
@jancborchardt should we merge into 9.0.2 too? |
👍 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If we got white upload icons, we could really use some white download ones.
I'm in need of some for the contacts app, and I think it should be added in core for future possible uses.
Tell me if you think this is a bad idea :)
@owncloud/designers @Henni