Make lock ttl configurable #23553
Merged
Make lock ttl configurable #23553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@icewind1991 there is something totally broken with the unit test execution - setting back to developing |
237b245 to
792598b
Compare
|
all fixed |
| * | ||
| * Any lock older than this will be automatically cleaned up. | ||
| * | ||
| * If not set this defaults the the either 1 hour or the php max_execution_time, whichever is higher. |
There was a problem hiding this comment.
"the the"
How to unset it to have it be the default ? Set to 0 ?
There was a problem hiding this comment.
How to unset it to have it be the default
Just not set it in the config
There was a problem hiding this comment.
fix the wording issue
792598b to
23bcf78
Compare
|
Looks fine, both db locking and redis locking still seem to work 👍 |
|
👍 |
23bcf78 to
cdedda9
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22591
Makes the lock ttl configurable in
config.phpand changes the default ttl to be either 1 hour or the php max_execution_time, whichever is higher.By using max_execution_time as ttl we make sure we don't run into the issue of removing a lock of a process that's still running.
@Ma1kavian can you verify that this fixes the problem (undo the change to the ttl you made and apply this patch, you shouldn't need to configure the ttl manually since it takes the max_execution_time into account)
cc @PVince81