[stable8.2] Run cleanup of expired DB file locks to background job #22868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes #22819 The old way fired a DELETE statement on each destruction of the DBLockingProvider. Which could cause a lot of queries. It's enough to run this every 5 minutes in a background job, which in the end could result in file locks that exists 5 minutes longer - in the worst case and for not properly released locks. This makes the DB based locking a lot more performant and could result in a similar performance to the Redis based locking provider.
|
By analyzing the blame information on this pull request, we identified @icewind1991, @nickvergessen and @schiesbn to be potential reviewers |
|
I tested this with an upgrade from 8.2.2 and it works just fine. |
|
👍 |
|
Tested, works 👍 |
|
Setting to 8.2.3 as discussed with @cmonteroluque |
|
Tested, looks good 👍 |
|
@cmonteroluque The failing test could be ignored for stable8.2 |
ghost
pushed a commit
that referenced
this pull request
Mar 4, 2016
[stable8.2] Run cleanup of expired DB file locks to background job
Closed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old way fired a DELETE statement on each destruction of the
DBLockingProvider. Which could cause a lot of queries. It's enough
to run this every 5 minutes in a background job, which in the end
could result in file locks that exists 5 minutes longer - in the
worst case and for not properly released locks.
This makes the DB based locking a lot more performant and could
result in a similar performance to the Redis based locking provider.
Backport of #22865
General backport approval is in #22865 (comment)
@cmonteroluque @PVince81 @karlitschek I just put this into 8.2.4 for now. Feel free to merge this to 8.2.3 if this is fine for you and it is tested properly.
cc @LukasReschke @icewind1991 @DeepDiver1975 @rullzer