Set default expiration date if none given on share creation

[rullzer]

When we create a share for the first time we should set the default
expiration date. If none is given.

This used to be the case. But I think I did it wrong when I reused it for updateShare as well.

Now there is a unit test for this.
Fixes #22642

@SergioBertolinSG is it possible to have intergration tests that test this part of the sharing API as well (so with the config stuff changing)?

@javiergonzper please verify this fixes it.

CC: @PVince81 @schiesbn @nickvergessen @MorrisJobke

[PVince81]

I can't reproduce the original issue from the web UI, probably because the order of calls is different ?

The code makes sense.

[PVince81]

Tested, works 👍

Here is the command to share a folder "test":
curl -X POST --data "path=test&shareType=3" http://admin:admin@localhost/owncloud/ocs/v2.php/apps/files_sharing/api/v1/shares

[xerc]

please add "expireDate" to the "Create a new Share" API-function

[PVince81]

@xerc #18651

[MorrisJobke]

Tested and works 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.