debug enhancements in subadminmiddleware.php #20185
Conversation
Displays the exception message on the 403 error page. Very usefull (not only for newbies) to debug, becaus a 403 page without any message or log file entry is very hard to interprete. In addition a logfile entry would be nice should I add it. First commit was incomplete, sorry about that.
|
@chludwig Thanks a lot for your contribution! Alternatively you can add a comment here where you state that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/ |
| @@ -71,7 +71,11 @@ public function beforeController($controller, $methodName) { | |||
| * @return TemplateResponse | |||
| */ | |||
| public function afterException($controller, $methodName, \Exception $exception) { | |||
| $response = new TemplateResponse('core', '403', array(), 'guest'); | |||
| $message = ''; | |||
| if (\OC::$server->getConfig()->getSystemValue('debug', false)) { | |||
There was a problem hiding this comment.
the config object needs to be injected via the ctor
I'd vote for something like https://github.com/master/core/commit/22e724e8292315f600b57a30716e26c1f1c04f66 instead. @chludwig Mind adjusting your PR? |
|
My contribution is MIT licensed. @LukasReschke @DeepDiver1975 For me it is hard to make your proposed changes, maybe someone else can help here. Thank you. |
@LukasReschke This is a dead link 🙈 |
|
@LukasReschke can you clarify ? |
|
Thanks a lot for your contribution! Alternatively you can add a comment here where you state that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/ |
|
Replaced by #22551 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Displays the exception message on the 403 error page. Very usefull (not only for newbies) to debug, becaus a 403 page without any message or log file entry is very hard to interprete. In addition a logfile entry would be a nice option.