Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "It is not possible to seek the video" #18501

Closed
wants to merge 1 commit into from
Closed

Fix "It is not possible to seek the video" #18501

wants to merge 1 commit into from

Conversation

binron
Copy link

@binron binron commented Aug 23, 2015

@scrutinizer-notifier
Copy link

A new inspection was created.

@ghost
Copy link

ghost commented Aug 23, 2015

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@PVince81
Copy link
Contributor

The better solution is to make the video player point at the Webdav endpoint, which supports http ranges

@binron
Copy link
Author

binron commented Sep 16, 2015

The idea was to support range requests for shared files.
Not just for video players, also for downloading big files (resume download)

E.g.: https://example.com/owncloud/index.php/s/zfT7yQhtF9WSzI3/download

@DeepDiver1975
Copy link
Member

files.php will die in 9.0 and 8.2 is closed for new features.

Thanks a lot for your contributions - but I have to reject this - sorry

@binron
Copy link
Author

binron commented Sep 16, 2015

@PVince81
Copy link
Contributor

Please note that in the future the Webdav endpoints will be used (#12353). There is also a Webdav endpoint already for public links. Webdav endpoints already support range requests.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants