Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jenkins] add download feedback #17227

Closed
wants to merge 7 commits into from
Closed

[Jenkins] add download feedback #17227

wants to merge 7 commits into from

Conversation

MorrisJobke
Copy link
Contributor

Jenkins PR for #17175

@ghost
Copy link

ghost commented Jun 29, 2015

💣 Test FAILed. 💣
nooo432

@LukasReschke
Copy link
Member

Well. Jenkins will fail also further if tests fail 🙊

@LukasReschke
Copy link
Member 

09:15:33 PhantomJS 1.9.8 (Linux 0.0.0) OCA.Files.FileList tests File selection Actions Download Opens download URL when clicking "Download" FAILED
09:15:33    TypeError: 'undefined' is not an object (evaluating 'sourceImage.replace')
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/apps/files/js/filelist.js:432
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/underscore/underscore.js:616
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery/jquery.min.js:5
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery/jquery.min.js:5
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery/jquery.min.js:5
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery-migrate/jquery-migrate.min.js:2
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery/jquery.min.js:5
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery/jquery.min.js:4
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery/jquery.min.js:4
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery/jquery.min.js:5
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/vendor/jquery/jquery.min.js:6
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/apps/files/tests/js/filelistSpec.js:1775
09:15:33 PhantomJS 1.9.8 (Linux 0.0.0) OCA.Files.FileList tests File selection Actions Download Downloads root folder when all selected in root folder FAILED
09:15:33    TypeError: Attempted to wrap redirect which is already wrapped
09:15:33        at wrapMethod (/var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/js/tests/lib/sinon-1.7.3.js:528)
09:15:33        at stub (/var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/js/tests/lib/sinon-1.7.3.js:1685)
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/apps/files/tests/js/filelistSpec.js:1783
09:15:33 PhantomJS 1.9.8 (Linux 0.0.0) OCA.Files.FileList tests File selection Actions Download Downloads parent folder when all selected in subfolder FAILED
09:15:33    TypeError: Attempted to wrap redirect which is already wrapped
09:15:33        at wrapMethod (/var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/js/tests/lib/sinon-1.7.3.js:528)
09:15:33        at stub (/var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/js/tests/lib/sinon-1.7.3.js:1685)
09:15:33        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/apps/files/tests/js/filelistSpec.js:1791
09:15:33 ......................
09:15:34 PhantomJS 1.9.8 (Linux 0.0.0) OCA.Files.FileList tests Handeling errors reloads the page on authentication errors FAILED
09:15:34    TypeError: Attempted to wrap redirect which is already wrapped
09:15:34        at wrapMethod (/var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/js/tests/lib/sinon-1.7.3.js:528)
09:15:34        at stub (/var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/core/js/tests/lib/sinon-1.7.3.js:1685)
09:15:34        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/apps/files/tests/js/filelistSpec.js:2215
09:15:34    ReferenceError: Can't find variable: redirectStub
09:15:34        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/apps/files/tests/js/filelistSpec.js:2236
09:15:34    ReferenceError: Can't find variable: redirectStub
09:15:34        at /var/jenkins/workspace/pull-request-analyser-ng-simple@2/label/SLAVE/apps/files/tests/js/filelistSpec.js:2222
09:15:34 ...........................................�[33mWARN [web-server]: �[39m404: /svg
09:15:34 .....................................

@MorrisJobke
Add proper download started feedback
9e6bfbf 
* this code adds a cookie when a special get parameter is set
* the content of this get parameter is used as value for the cookie
* the cookie expires after 20 seconds
* the JS code checks every 500 milliseconds for the cookie
  -> if the cookie is set the request returned and the download is started
@scrutinizer-notifier
Copy link

A new inspection was created.

@MorrisJobke
Copy link
Contributor Author

Well. Jenkins will fail also further if tests fail 🙊

In the other branch it always failed due to the git clone exception -.-

@LukasReschke
Copy link
Member

20 cent on: Now this git clone will also fail 🙈

@ghost
Copy link

ghost commented Jun 29, 2015

💣 Test FAILed. 💣
nooo432

@ghost
Copy link

ghost commented Jun 29, 2015

💣 Test FAILed. 💣
nooo432

@MorrisJobke MorrisJobke deleted the jenkins-add-download-feedback branch June 29, 2015 21:34
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @LukasReschke @scrutinizer-notifier