Add feedback for public page download #17160
Conversation
|
I don't think it is possible, because the download is done by redirecting the page to the download URL. |
Is the scenario reasonable? Maybe I simply use the showTemporary? |
|
You could show a notification just before doing the OC.redirect, yes. |
That's what this PR does ;) |
| @@ -133,6 +133,9 @@ OCA.Sharing.PublicApp = { | |||
| img.appendTo('#imgframe'); | |||
| } | |||
|
|
|||
| $('#download, #downloadFile').click(function (e) { | |||
| OC.Notification.show(t('files_sharing', 'Download has started. Please wait ... ')); | |||
There was a problem hiding this comment.
Typographic … instead of ... please :)
There was a problem hiding this comment.
:D nice
Also, no space after the … please. And simpler »Download started.« instead of »Download has started.«
|
🚀 Test PASSed.🚀 |
| @@ -133,6 +133,9 @@ OCA.Sharing.PublicApp = { | |||
| img.appendTo('#imgframe'); | |||
| } | |||
|
|
|||
| $('#download, #downloadFile').click(function (e) { | |||
There was a problem hiding this comment.
There are two download buttons on that page ;)
There was a problem hiding this comment.
- Top right
- below the preview on single file public shares
9b7814b to
53f2ce8
Compare
53f2ce8 to
c14452d
Compare
|
A new inspection was created. |
|
Rather than putting a notification on the top of the page, we should change the icon of the download button to (Also see how we do that in the Mail app for attachments.) |
|
🚀 Test PASSed.🚀 |
| @@ -133,6 +133,9 @@ OCA.Sharing.PublicApp = { | |||
| img.appendTo('#imgframe'); | |||
| } | |||
|
|
|||
| $('#download, #downloadFile').click(function (e) { | |||
| OC.Notification.showTemporary(t('files_sharing', 'Download started. Please wait …')); | |||
There was a problem hiding this comment.
Use regular three dots "..." instead of unicode three dots. Also, no space before the three dots.
There was a problem hiding this comment.
Guys....decide on one way. It was requested to use the unicode ellipsis, because it is an ellipsis and not three dots ;)
|
Obsoleted by #17175 ? |
The issue is, that once somebody click on download and the server needs some time to fetch the file from a storage, there is the possibility that the user think that nothing happens and then click again. This simply adds a feedback for the user. The issue can be simulated by adding
sleep(5);to the top ofdownloadShare()method inapps/files_sharing/lib/controllers/sharecontroller.php.Ref owncloud/consulting#14
Does anybody know a way to get notified, once the download actually has started - the response returned from the server? cc @PVince81 @jancborchardt
cc @owncloud/designers