Add support for Raw files previews

[oparoz]

Replaces #13652

Solution for

#13650
owncloud-archive/apps#439
owncloud-archive/apps#1113

Including media type migration and tests

Supported formats:

• Sony Alpha RAW .arw
• Canon RAW 2 .cr2
• Digital Camera Raw .dcr
• Digital Negative .dng
• EPSON RAW .erf
• Intelligent Image Quality RAW .iiq
• Kodak DC40/DC50 RAW .kdc
• Kodak DC25 RAW .k25
• Nikon RAW .nef
• Mamiya RAW .mef
• Olympus RAW .orf
• Panasonic RAW .rw2
• PENTAX RAW .pef
• Fujifilm RAW .raf
• Sony RAW File .srf .sr2
• SIGMA RAW .xrf

Requirements

• ImageMagick
• ufraw as an ImageMagick delegate for DNG
• ufraw-batch must be reachable from PHP
• PR Keep the extension in temp files #13654, which is a fix for \OC_Helper::tmpFile can break Imagemagick #12282
• A gallery app which supports all media types supported by ownCloud

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10443/
Test PASSed.

[DeepDiver1975]

👍 looks good

[DeepDiver1975]

@nickvergessen @MorrisJobke mind to review? THX

[nickvergessen]

Wait for #14857 which just needs a rebase due to a merge conflict and then put this in an app?

[oparoz]

@nickvergessen - OK, I can do it via an app, once the other ImageMagick providers have been moved to an app, so that I can use that as an example.

[DeepDiver1975]

and then put this in an app?

well - mime changes have to go to core - moving the preview impl to an app - yes

[oparoz]

@DeepDiver1975 - #14927 is for the new media types

[nickvergessen]

This should be an app now

[oparoz]

I can't find the other providers in apps and all the current providers are still in https://github.com/owncloud/core/tree/master/lib/private/preview

[nickvergessen]

Doesn't matter, its a new provider so it should not be here.
This is just a "memory", so we don't merge it like that

[oparoz]

OK, waiting for #14803 , with one week to go.

[nickvergessen]

instead of waiting, send a patch?

[oparoz]

I don't want to be the guinea pig on this. It was decided that providers need to exist as apps and someone must have a clear vision on how this is going to work, without using any private APIs and without breaking existing apps.
There needs to be at least one provider moved to an app, to make sure this actually works and to serve as a guide for app devs.

Good examples would be a sub-class of the bitmap or office providers since each requires 2 apps (base and sub) which need to communicate with each other using undefined methods (inter-app dependencies).
The movie provider which relies on core classes would be a good case for later as it might highlight missing public methods required to get it to run.

[DeepDiver1975]

@oparoz @nickvergessen what's the status on this? THX

[oparoz]

My take is that preview providers as apps is an untested concept. There is no process, no documentation.
For this particular provider, the parent class would be in core and in the private domain.
If the bitmap class is converted into an app, there is no definition on how to manage inter-app dependencies for all the other apps which would extend that one. The alternative being to have a "Bitmap" app which would be extended to support more formats via PRs.

So, from my point of view, there is no harm in adding this provider as the last one and then move everything out for 8.2. It's going to have to be done anyway.
Starting with this one and then modifying it several times to make it work like the rest of them seems like a waste of time.

@nickvergessen probably has a better idea of how this will all work in the future.

[DeepDiver1975]

So, from my point of view, there is no harm in adding this provider as the last one and then move everything out for 8.2. It's going to have to be done anyway.

sounds reasonable to be

@oparoz can I ask you to rebase this branch please - THX
@nickvergessen any objections with respect to the suggested approach? THX

[nickvergessen]

fine by me

[oparoz]

OK, I'll rebase and we can talk about the next steps here:
#14803

If we're confident that everything will be in place for 8.2, this feature in core should be marked as depreciated. That way we can progressively create replacement apps and delete the whole thing in core for the launch of 8.2

[MorrisJobke]

@oparoz I uploaded an image from the linked site and one of my raw images:
Both get this:

{"reqId":"hJYA0jx8MQeSEALUxgI0","remoteAddr":"127.0.0.1","app":"core","message":"Generating preview for \"\/\/RAW_LEICA_M8.DNG\" with \"OC\\Preview\\Raw\"","level":0,"time":"2015-04-12T08:17:17+00:00","method":"GET","url":"\/master\/index.php\/core\/preview.png?file=%2F%2FRAW_LEICA_M8.DNG&c=863a945b828fefdca8e7fb6d40889e06&x=36&y=36&forceIcon=0"}
{"reqId":"hJYA0jx8MQeSEALUxgI0","remoteAddr":"127.0.0.1","app":"core","message":"ImageMagick says: unable to open image `\/tmp\/magick-2219lYgfWFmGAjE9.ppm': No such file or directory @ error\/blob.c\/OpenBlob\/2675","level":3,"time":"2015-04-12T08:17:17+00:00","method":"GET","url":"\/master\/index.php\/core\/preview.png?file=%2F%2FRAW_LEICA_M8.DNG&c=863a945b828fefdca8e7fb6d40889e06&x=36&y=36&forceIcon=0"}

[oparoz]

I suspect you haven't installed ufraw-batch so that ImageMagick can convert Raw images to PNG.

[MorrisJobke]

I suspect you haven't installed ufraw-batch so that ImageMagick can convert Raw images to PNG.

Is this somewhere written? Otherwise we need a hint that this is needed. I would like to have it in the sample config too.

[oparoz]

I think that in general, configuring ImageMagick is out of scope of a PR, but since you're the 2nd person running into the issue, a little hint in the sample config wouldn't hurt.

Would that be enough you think?

[nickvergessen]

Well if we can check that programmatically, we should do it, where we check for the imagick plugin

[oparoz]

I could add a check to the class

\OC_Helper::canExecute("ufraw-batch")

It should work for most people, but will hinder the move to the apps "domain", because there is no public method equivalent.

[scrutinizer-notifier]

The inspection completed: 4338 Issues, 132 Patches

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11589/
🚀 Test PASSed.🚀

[oparoz]

The comment has been added, as well as a simple check for the helper binary.
@georgehrke - Could you see if this works on your setup?

[PVince81]

Moving this enhancement to 8.2

[oparoz]

@PVince81 - There is no reason to push this back. It works and is ready to be merged.

[PVince81]

The reason is feature freeze. Only bugfixes are allowed.
From what I understand this is an addition/enhancement/new feature, so it will have to wait for 8.2.

[oparoz]

This should not be considered a last minute enhancement. The original PR has been created 3 months ago, long before the feature freeze deadline. Even the last revision is from 5-6 weeks ago. It was added to the list of planned features for 8.1 and it doesn't touch any vital system component unlike some of the bug fixing which has been happening these past weeks.

[oparoz]

Never mind. I've just re-read your definition of Feature Freeze and PRs have to be merged before the deadline. I should have hassled people ;). As providers aren't accepted beyond 8.1, I'll just delete this PR.

[enoch85]

What happened with this? Will it be included in coming releases?

[oparoz]

Unfortunately, no, but this can be added via apps.

[enoch85]

@oparoz Asking because I have some requests here: http://www.sweclockers.com/forum/trad/1212245-stora-owncloud-traden

Any plans on including this soon?

[oparoz]

It will never be part of the core, but if you look at the code, you can see that it shouldn't be too difficult for an apps developer to build.
Maybe use BountySource?

[mbewley]

Out of interest, where is this at? I'm trying to figure out whether preview of RAW images (specifically ORF) is possible in owncloud - it would be very handy for my workflow!

[oparoz]

@mbewley - It is possible, but it requires the development of an app. Since so few people are interested, I'm not sure I'm going to sell one (thousands to set up vs hundreds in subscriptions).
It seems BountySource doesn't offer fundraisers any more, but I'm sure there are alternative systems which could be used to incite developers to come up with a solution.
Could also be a good Summer of Code project for 2016.