Introduce buildPath() in Storage\Local to reduce the difference to MappedLocal #12462
Conversation
|
Could also name the method |
| * @param bool $create | ||
| * @return string | ||
| */ | ||
| private function buildPath($path, $create = true) { |
There was a problem hiding this comment.
What's $create for ? Legacy ?
There was a problem hiding this comment.
It's a parameter that exists in the mappedlocal.php implementation. It seems to be unused thou, will investigate tomorrow
43434bb to
07f9f43
Compare
|
@PVince81 The parameter was never set, so I removed it and made the method in the mapper work with Also renamed the method as per above |
| * @return string | ||
| */ | ||
| private function buildPath($path, $create = true) { | ||
| private function getSourcePath($path) { |
There was a problem hiding this comment.
Please add PHPDoc comment that tells what this function does
|
Hmm, after looking at the wrapper, the question is whether we should allow wrappers to override/extend "getSourcePath()" ? If yes, that method needs to be made public. @icewind1991 what do you think ? |
|
@PVince81 the wrapper must not overwrite it, because then the wrapper will break windows?! Oo |
07f9f43 to
4f1bbc4
Compare
|
Made the method protected |
|
The inspection completed: 13 new issues, 3 updated code elements |
|
🚀 Test PASSed. 🚀 |
|
Wrappers shouldn't overwrite the |
|
👍 code looks good |
|
Did not destroy the known universe 👍 |
…dpath Introduce buildPath() in Storage\Local to reduce the difference to MappedLocal
First step towards #12460
@MorrisJobke @LukasReschke @DeepDiver1975