Introduce app info xml parser including basic unit test - necessary for ... #12393
Conversation
|
🚀 Test PASSed. 🚀 |
|
🚀 Test PASSed. 🚀 |
|
@PVince81 @LukasReschke @schiesbn @blizzz please review - thx |
| */ | ||
| public function parse($file) { | ||
| if (!file_exists($file)) { | ||
| return null; |
There was a problem hiding this comment.
Why not throwing an exception?
There was a problem hiding this comment.
keep the current behavior
|
Besides the comments: Great stuff 👍 |
|
Tested is only the successful case, but what if the XML file is broken or invalid? There should be defined way of handling this, too. |
will add such tests asap - thx |
|
@LukasReschke @blizzz thanks for the review - comments have been addressed |
f3f5335 to
52f7176
Compare
|
code looks, apps page is still working 👍 |
|
🚀 Test PASSed. 🚀 |
|
🚀 Test PASSed. 🚀 |
|
|
||
| /** | ||
| * @param string $file | ||
| * @return null|array |
There was a problem hiding this comment.
Document that "null" should be considered an error?
There was a problem hiding this comment.
well - I expect changes to the interface in the next iterations anyhow - will take care if it ...
|
👍 |
|
|
52f7176 to
5ce34fb
Compare
|
will merge after jenkins success |
|
The inspection completed: 9 updated code elements |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 17 lines...] > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/12393/merge^{commit} # timeout=10Checking out Revision ea5889f849b393a0587a19bc9b3e29e327062065 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f ea5889f849b393a0587a19bc9b3e29e327062065 > git rev-list f3818a6b8eb28f1b42a7da6c75b12c6f71c216c3 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveCleaning workspace > git rev-parse --verify HEAD # timeout=10Resetting working tree > git reset --hard # timeout=10 > git clean -fdx # timeout=10 > git submodule foreach --recursive git reset --hard # timeout=10 > git submodule foreach --recursive git clean -fdx # timeout=10Triggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 second💣 Test FAILed. 💣 |
|
Looks similar to #9803 |
|
To bad this needs to be redeveloped after waiting on the other PR :-( |
well - shit happens - but to be honest: it's within the responsibility of every dev to get his changes merged - if stuff is lost on the road .... No offense - happens to my PRs as well 🙊 |
...#10777