Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theseUsersHaveBeenCreatedUsingTheOccCommand is missing a check #37828

Closed
phil-davis opened this issue Aug 19, 2020 · 0 comments · Fixed by #37839
Closed

theseUsersHaveBeenCreatedUsingTheOccCommand is missing a check #37828

phil-davis opened this issue Aug 19, 2020 · 0 comments · Fixed by #37839
Assignees
@swoichha
Labels
dev:acceptance-tests QA:p2 QA:team

Comments

@phil-davis
Copy link
Contributor

https://github.com/owncloud/core/blob/master/tests/acceptance/features/bootstrap/OccUsersGroupsContext.php#L129

theseUsersHaveBeenCreatedUsingTheOccCommand() ends with:

\in_array($tableUsername, $usernameArray, true);

which does nothing - the true/false value is not used.

Fix it so that it actually asserts something useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swoichha swoichha

Labels
dev:acceptance-tests QA:p2 QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tests-Only] Assert created user owncloud/core
2 participants
@phil-davis @swoichha