Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Assert created user #37839

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

swoichha
Copy link
Contributor

Description

Assert created users with the table of users required to be created.

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@swoichha swoichha force-pushed the test-create-user-occCommand branch from be17fea to e53ddf1 Compare August 24, 2020 05:45
@swoichha swoichha requested review from phil-davis and dpakach August 24, 2020 05:46
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #37839 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37839   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19392    19392           
=========================================
  Files          1284     1284           
  Lines         75755    75755           
  Branches       1333     1333           
=========================================
  Hits          49057    49057           
  Misses        26306    26306           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.94% <ø> (ø) 19392.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1048cd5...16a9f07. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #37839 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37839   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19392    19392           
=========================================
  Files          1284     1284           
  Lines         75755    75755           
  Branches       1333     1333           
=========================================
  Hits          49057    49057           
  Misses        26306    26306           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.94% <ø> (ø) 19392.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1048cd5...16a9f07. Read the comment docs.

@swoichha swoichha requested a review from dpakach August 25, 2020 04:13
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #37839 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37839      +/-   ##
============================================
- Coverage     64.75%   64.75%   -0.01%     
- Complexity    19392    19396       +4     
============================================
  Files          1284     1285       +1     
  Lines         75755    75762       +7     
  Branches       1333     1333              
============================================
  Hits          49057    49057              
- Misses        26306    26313       +7     
  Partials        392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (-0.01%) 19396.00 <ø> (+4.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...aring/appinfo/Migrations/Version20200823121322.php 0.00% <0.00%> (ø) 4.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1048cd5...aa04247. Read the comment docs.

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

theseUsersHaveBeenCreatedUsingTheOccCommand is missing a check
3 participants