Move apps from apps to apps2 folder can cause issues #29807

mmattel · 2017-12-10T20:09:42Z

Steps to reproduce

disable an app
enable maintenance mode
move app from folder apps/ to apps2/
disable maintenance mode
try to reenable app

Expected behaviour

app should be enabled

Actual behaviour

4 example apps I tried
Info, Musik worked

Temporary Fix

In maintenace mode on, I needed to delete the app physically, then maintenance mode off, then I was able to download the app from the Marketplace (before it was identified as installed).

Server configuration

Operating system: Ubuntu 16.04

Web server: nginx

Database: mysql

PHP version: 7

ownCloud version: 10.0.4

Updated from an older ownCloud or fresh install: updated

Where did you install ownCloud from: tar

Signing status (ownCloud 9.0 and above):

No errors have been found.

The content of config/config.php:

{
    "system": {
        "instanceid": "oct7bkicorxf",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "xyz"
        ],
        "datadirectory": "\/var\/www\/owncloud\/data",
        "overwrite.cli.url": "https:\/\/xyz",
        "dbtype": "mysql",
        "version": "10.0.4.4",
        "dbname": "owncloud",
        "dbhost": "localhost",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "logtimezone": "Europe\/Vienna",
        "installed": true,
        "filelocking.enabled": "true",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "localhost",
            "port": 6379,
            "timeout": 0,
            "dbindex": 0
        },
        "filesystem_check_changes": 1,
        "loglevel": 2,
        "mail_smtpmode": "smtp",
        "mail_from_address": "xyzzy",
        "mail_smtpsecure": "tls",
        "mail_domain": "xyzzy",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtphost": "xyzzy",
        "mail_smtpport": "587",
        "maintenance": false,
        "theme": "",
        "preview_max_scale_factor": 1,
        "enabledPreviewProviders": {
            "0": "OC\\Preview\\PNG",
            "1": "OC\\Preview\\JPEG",
            "2": "OC\\Preview\\GIF",
            "11": "OC\\Preview\\Illustrator",
            "12": "OC\\Preview\\Postscript",
            "13": "OC\\Preview\\Photoshop",
            "14": "OC\\Preview\\TIFF"
        },
        "excluded_directories": [
            ".snapshot",
            "~snapshot"
        ],
        "upgrade.automatic-app-update": true,
        "quota_include_external_storage": false,
        "singleuser": false,
        "apps_paths": [
            {
                "path": "\/var\/www\/owncloud\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/owncloud\/apps2",
                "url": "\/apps2",
                "writable": true
            }
        ]
    }
}

List of activated apps:

Enabled:
  - activity: 2.3.6
  - comments: 0.3.0
  - configreport: 0.1.1
  - dav: 0.3.2
  - federatedfilesharing: 0.3.1
  - federation: 0.1.0
  - files: 1.5.1
  - files_clipboard: 0.6.2
  - files_external: 0.7.1
  - files_external_dropbox: 1.0.0
  - files_external_ftp: 0.2.0
  - files_pdfviewer: 0.8.2
  - files_sharing: 0.10.1
  - files_texteditor: 2.2.1
  - files_trashbin: 0.9.1
  - files_versions: 1.3.0
  - files_videoplayer: 0.9.8
  - firstrunwizard: 1.1
  - gallery: 16.0.2
  - market: 0.2.3
  - music: 0.5.5
  - notifications: 0.3.2
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - templateeditor: 0.1
  - updatenotification: 0.2.1
Disabled:
  - encryption
  - external
  - theme-example
  - user_external

Are you using external storage, if yes which one: local, smb, ftp, dropbox...

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Safari

Operating system: MacOs

Logs

ownCloud log (data/owncloud.log)

Based on the examples of Gallery and Files_Clipboard

{"reqId":"ug4BQZSMIge2bgohLY4g","level":3,"time":"2017-12-10T20:34:16+01:00","remoteAddr":"w.x.y.z","user":"user_1","app":"PHP","method":"GET","url":"\/apps\/files","message":"require_once(\/var\/www\/owncloud\/apps\/gallery\/appinfo\/app.php): failed to open stream: No such file or directory at \/var\/www\/owncloud\/lib\/private\/legacy\/app.php#243"}
{"reqId":"ug4BQZSMIge2bgohLY4g","level":3,"time":"2017-12-10T20:34:16+01:00","remoteAddr":"w.x.y.z","user":"user_1","app":"PHP","method":"GET","url":"\/apps\/files","message":"require_once(): Failed opening required '\/var\/www\/owncloud\/apps\/gallery\/appinfo\/app.php' (include_path='\/var\/www\/owncloud\/apps:\/var\/www\/owncloud\/apps2') at \/var\/www\/owncloud\/lib\/private\/legacy\/app.php#243"}

{"reqId":"NINdBFMbTzoEZfZlTjbw","level":3,"time":"2017-12-10T20:34:24+01:00","remoteAddr":"w.x.y.z","user":"user_1","app":"PHP","method":"GET","url":"\/apps\/files","message":"require_once(\/var\/www\/owncloud\/apps\/files_clipboard\/appinfo\/app.php): failed to open stream: No such file or directory at \/var\/www\/owncloud\/lib\/private\/legacy\/app.php#243"}
{"reqId":"NINdBFMbTzoEZfZlTjbw","level":3,"time":"2017-12-10T20:34:24+01:00","remoteAddr":"w.x.y.z","user":"user_1","app":"PHP","method":"GET","url":"\/apps\/files","message":"require_once(): Failed opening required '\/var\/www\/owncloud\/apps\/files_clipboard\/appinfo\/app.php' (include_path='\/var\/www\/owncloud\/apps:\/var\/www\/owncloud\/apps2') at \/var\/www\/owncloud\/lib\/private\/legacy\/app.php#243"}

The text was updated successfully, but these errors were encountered:

ownclouders · 2017-12-10T20:17:51Z

GitMate.io thinks the contributor most likely able to help you is @PVince81.

PVince81 · 2017-12-11T15:31:59Z

@mmattel did you check if oc_appconfig has hard-coded paths ?

mmattel · 2017-12-11T16:16:29Z

Just looked into the table.
No app in the table has a configkey/configvalue which contains a path or path-component.
There are about 138 entries from varios apps (incuding some orphans where the app does not exist anymore... but anyhow this is a different story 😄 )

mmattel · 2017-12-11T16:28:26Z

The text gets triggered at: core/settings/js/admin-apps.js at line 293

}).fail(function() {
	// server borked, emergency disable app
	$.post(OC.webroot + '/index.php/disableapp', {appid: appId}, function() {
		OC.Settings.Apps.showErrorMessage(
			appId,
			t('settings', 'Error: this app cannot be enabled because it makes the server unstable')
		);

settermjd · 2017-12-19T14:41:55Z

Just confirming @mmattel's work that I can move an app into a new directory, but as there is no path reference, the move will always be slightly broken.

PVince81 · 2017-12-19T14:44:44Z

@VicDeo any clues as you're familiar with the resource locator ?

VicDeo · 2017-12-19T14:48:26Z

@PVince81 I haven't touched resource locator itself yet, could be related to caching because AppManager uses cache to store app values

settermjd · 2017-12-19T15:00:08Z

From researching the codebase, it looks like it will need a bit of work to implement. However, it might be quite achievable. I'll add an issue to document what I think's required.

mmattel · 2017-12-19T15:05:27Z

@settermjd pls. keep me posted. Very interested about your findings 😃

settermjd · 2017-12-20T05:31:31Z

I've created an issue, but I'm not sure if it's effectively a duplicate of this one. That said, it was quite interesting to follow the logic in the code to, almost, understand what's going on.

ownclouders · 2018-01-28T01:06:36Z

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

ownclouders · 2018-03-09T01:07:36Z

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

cdamken · 2018-03-22T14:37:04Z

What happens if the app is in both folders?
Which one will be active?
and in case of upgrades - which will be updated?

mmattel · 2018-03-22T15:33:11Z

ad 1.) don´t know... but would be interested in the result, easy testing - just try 😄

ad 2.) in case you follow the config.sample.php description of apps_path, the apps folder is read only (core apps) while the apps2 directory is read-write and apps can be updated there.

See also issue #29839 ([Feature Request] make the apps2 folder default used in new installations) to make apps2 default available when setting up a new instance.

VicDeo · 2018-03-23T09:26:20Z

@cdamken

What happens if the app is in both folders?

By design the most recent app should be loaded (by version). If the versions are the same - behavior is undefined, I guess app from the very first appdir will be loaded

and in case of upgrades - which will be updated?

By design one that is located in a writable appdir

#29807 documents that moving apps from the core to a non-core apps folder manually can cause issues. Given that and the discussion in owncloud-archive/documentation#4276, I decided to start writing an app:move command, to make moving apps from the core apps directory, to a custom non-core apps directory simpler and less messy. When finished, the command will be able to: - List apps that can be moved - List any non-core app directories - Check that non-core app directories exist - Move one or more apps from the core apps directory to a non-core apps directory The other reason for doing this is to better familiarise myself with ownCloud's internals — something that, for quite some time, I've felt I've been lacking, and that has been hindering me from doing my work better.

ownclouders added the Type:Bug label Dec 10, 2017

mmattel mentioned this issue Dec 13, 2017

[Feature Request] make the apps-external folder default used in new installations #29839

Closed

settermjd mentioned this issue Dec 20, 2017

Better document how to use custom app directories and how to move apps between directories owncloud-archive/documentation#3643

Merged

ownclouders added the status/STALE label Jan 20, 2018

ownclouders closed this as completed Jan 28, 2018

ownclouders removed the status/STALE label Jan 28, 2018

PVince81 reopened this Jan 29, 2018

ownclouders added the status/STALE label Mar 1, 2018

ownclouders closed this as completed Mar 9, 2018

ownclouders removed the status/STALE label Mar 9, 2018

cdamken reopened this Mar 22, 2018

ownclouders added the status/STALE label Apr 23, 2018

settermjd mentioned this issue Aug 17, 2018

Create an app:move command #32368

Closed

10 tasks

ownclouders removed the status/STALE label Aug 17, 2018

mmattel closed this as completed Jan 10, 2019

lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move apps from apps to apps2 folder can cause issues #29807

Move apps from apps to apps2 folder can cause issues #29807

mmattel commented Dec 10, 2017

ownclouders commented Dec 10, 2017

PVince81 commented Dec 11, 2017

mmattel commented Dec 11, 2017

mmattel commented Dec 11, 2017

settermjd commented Dec 19, 2017

PVince81 commented Dec 19, 2017

VicDeo commented Dec 19, 2017

settermjd commented Dec 19, 2017

mmattel commented Dec 19, 2017

settermjd commented Dec 20, 2017

ownclouders commented Jan 28, 2018

ownclouders commented Mar 9, 2018

cdamken commented Mar 22, 2018

mmattel commented Mar 22, 2018

VicDeo commented Mar 23, 2018 •

edited

Loading

Move apps from apps to apps2 folder can cause issues #29807

Move apps from apps to apps2 folder can cause issues #29807

Comments

mmattel commented Dec 10, 2017

Steps to reproduce

Expected behaviour

Actual behaviour

Temporary Fix

Server configuration

Client configuration

Logs

ownCloud log (data/owncloud.log)

ownclouders commented Dec 10, 2017

PVince81 commented Dec 11, 2017

mmattel commented Dec 11, 2017

mmattel commented Dec 11, 2017

settermjd commented Dec 19, 2017

PVince81 commented Dec 19, 2017

VicDeo commented Dec 19, 2017

settermjd commented Dec 19, 2017

mmattel commented Dec 19, 2017

settermjd commented Dec 20, 2017

ownclouders commented Jan 28, 2018

ownclouders commented Mar 9, 2018

cdamken commented Mar 22, 2018

mmattel commented Mar 22, 2018

VicDeo commented Mar 23, 2018 • edited Loading

VicDeo commented Mar 23, 2018 •

edited

Loading