db/adapter.php is printing error page instead of passing along the Exception

[blizzz]

In that part https://github.com/owncloud/core/blob/master/lib/private/db/adapter.php#L74 the Adapter catches the Exception as delivered by Doctrine and outputs an error page. That makes application unable to respond properly on database issues.

Instead printing the error page, we can keep logging this error and throwing the Exception again. Since we have a global catch, we would not end up in a blank page, so it should be safe to do so.

Opinions? @DeepDiver1975 @MorrisJobke @butonic

[MorrisJobke]

@blizzz Sounds good. And we should use our global exception handling where it is useful. Maybe not log the error there but add the information to the Exception (use HintException) and then it will be displayed to the user (if debug session) and written to the log in the global exception handling mechanism. Am I correct @LukasReschke

[LukasReschke]

An uncatched exception will be displayed fully to the user if debug session, otherwise a generic error page is shown. An Hint Exception will show the hint to the user.

[DeepDiver1975]

👍 yes - we for sure need to get rid of all these code pieces - the top level code has to catch any exception and handle them properly - refs #11834