Fix 'Trying to access array offset on value of type bool'

owncloud · Dec 19, 2019 · e0e4fd1 · e0e4fd1
1 parent 000dca2
commit e0e4fd1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/private/Files/Cache/Cache.php b/lib/private/Files/Cache/Cache.php
@@ -110,7 +110,7 @@ public function getNumericStorageId() {
 	 * get the stored metadata of a file or folder
 	 *
 	 * @param string | int $file either the path of a file or folder or the file id for a file or folder
-	 * @return ICacheEntry|false the cache entry as array of false if the file is not found in the cache
+	 * @return ICacheEntry|false the cache entry as array or false if the file is not found in the cache
 	 */
 	public function get($file) {
 		if (\is_string($file) or $file == '') {

diff --git a/tests/lib/Cache/FileCacheTest.php b/tests/lib/Cache/FileCacheTest.php
@@ -84,8 +84,8 @@ protected function setUp(): void {
 	}
 
 	protected function tearDown(): void {
-		if ($this->instance) {
-			$this->instance->remove('hack', 'hack');
+		if ($this->instance->get('hack') !== null) {
+			$this->instance->remove('hack');
 		}
 
 		parent::tearDown();