Multiselect functionalty targeting https://github.com/owncloud/android/issues/596 #718
Conversation
1. allows multiselect during upload for select applications 2. Added an api check, multiselect is only supported on api level 18+
| requestSimpleUpload(data, resultCode); | ||
|
|
||
| //getClipData is only supported on api level 16+ | ||
| if (data.getData() == null && Build.VERSION.SDK_INT >= 16){ |
There was a problem hiding this comment.
In other occasion, just for clarifying, maybe it is better to use: Build.VERSION_CODES.JELLY_BEAN
|
@jabarros , the code has been updated so it has the build version instead of an int representing the api level. We also merged with the latest develop. But Travis CI is for some reason complaining now, I'll see if I can figure out why. |
|
Thanks @Pro9! :) |
|
I have no idea why it doesn't build in the pull request, this is the same code and it builds: https://travis-ci.org/owncloudChalmers/android/builds/42838339 |
|
Please, merge develop again. There is some problem with the building via Gradle in Travis, so we removed it for the moment from .travis.yml. |
|
@davivel I merged it again and travis passed |
|
@Pro9, there is a bug using android v.5.0. It would be great if you also update the branch with develop, because there are some new features. |
|
Hi @purigarcia I'm unable to find the bug in android v.5.0, It works for me. What exactly is it that isn't working? |
|
Hi @Pro9 , Files are not uploaded, a notification "upload fails" is shown |
|
Hi @Pro9, in the end this is not related to your contribution. We kept on validating it |
|
👍 Merging. Thanks, @Pro9 |
Multiselect functionalty targeting #596
Multiselect functionality only works on api level 18+ and on applications that has included that functionality. As pointed out in the issue it may not be clear for the user why it works in some applications and not in others, but until you have decided how to handle that this code adds multiselect for apps that support it. (multiselect has been tested on Google+ Photos app)