Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some files after removing submodule #4186

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Oct 10, 2023

SETUP.md

SETUP.md file is intended for new contributors to get ready with the proper environment. After removing the submodule, some actions are no longer required:

  • cloning repo with the --recursive option
  • git submodule update command to get last reference.

Release template

Release branch no longer required in release template for library

Feature request template

Removed PR section at the end of the template

If any other file requires attention or changes, please ping or add by yourself.

@jesmrec jesmrec changed the title Remove submodule references in SETUP.md file Update some files after removing submodule Oct 10, 2023
@jesmrec jesmrec force-pushed the fix/updateRepoDocs branch from a8beed3 to 5d8052a Compare October 10, 2023 11:25
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's cool to have everything in the same repo, and easier for us as well.
It's approved from my side, but I don't add an approval here because I think this PR is also a great opportunity to add some changes to the issue template (remove the final section "Related PR"). You can do it or I can do it myself, as you want 😃

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 10, 2023

go ahead!

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Oct 10, 2023

I uploaded the changes @jesmrec. Just let me know if you approve them and if so, I'll approve the PR 😀
I also edited the main comment to keep track of all the changes in this PR

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 10, 2023

@JuancaG05 the aim of removing the PR section is because the PR points to the app?

@JuancaG05
Copy link
Collaborator

@JuancaG05 the aim of removing the PR section is because the PR points to the app?

Not only that. On the one hand, it included 2 items, one for the app PR and another one for the library PR (which won't be necessary anymore), and on the other hand, this section wasn't being used lately because we link the PR directly in the issue, in the "Development" section, which is the native way that GitHub provides us and I think it's better

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 11, 2023

That's OK for me 👍

@JuancaG05
Copy link
Collaborator

So approved on my side 👍

@jesmrec jesmrec merged commit adad071 into master Oct 11, 2023
@jesmrec jesmrec deleted the fix/updateRepoDocs branch October 11, 2023 07:09
jesmrec added a commit that referenced this pull request Oct 20, 2023
Update some files after removing submodule
Aitorbp pushed a commit that referenced this pull request Feb 5, 2024
Update some files after removing submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants