-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some files after removing submodule #4186
Conversation
a8beed3
to
5d8052a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It's cool to have everything in the same repo, and easier for us as well.
It's approved from my side, but I don't add an approval here because I think this PR is also a great opportunity to add some changes to the issue template (remove the final section "Related PR"). You can do it or I can do it myself, as you want 😃
go ahead! |
8f95015
to
d649fe1
Compare
I uploaded the changes @jesmrec. Just let me know if you approve them and if so, I'll approve the PR 😀 |
@JuancaG05 the aim of removing the PR section is because the PR points to the app? |
Not only that. On the one hand, it included 2 items, one for the app PR and another one for the library PR (which won't be necessary anymore), and on the other hand, this section wasn't being used lately because we link the PR directly in the issue, in the "Development" section, which is the native way that GitHub provides us and I think it's better |
That's OK for me 👍 |
So approved on my side 👍 |
Update some files after removing submodule
Update some files after removing submodule
SETUP.md
SETUP.md
file is intended for new contributors to get ready with the proper environment. After removing the submodule, some actions are no longer required:--recursive
optiongit submodule update
command to get last reference.Release template
Release branch no longer required in release template for library
Feature request template
Removed PR section at the end of the template
If any other file requires attention or changes, please ping or add by yourself.