Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump exoplayer to version 2.13.2 #3116

Merged
merged 1 commit into from
Mar 12, 2021
Merged

bump exoplayer to version 2.13.2 #3116

merged 1 commit into from
Mar 12, 2021

Conversation

theScrabi
Copy link
Contributor

Bump Exoplayer to version 2.13.1

@theScrabi theScrabi self-assigned this Feb 25, 2021
@theScrabi theScrabi force-pushed the bump_exoplayer branch 2 times, most recently from dae11c2 to 40b64c1 Compare February 25, 2021 13:13
@abelgardep abelgardep self-requested a review February 25, 2021 13:27
abelgardep
abelgardep approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Ready to QA @jesmrec

@jesmrec jesmrec added this to the 2.17-current milestone Feb 25, 2021
@abelgardep
Copy link
Contributor

A new version was released yesterday: 2.13.2 Let's bump to the latest one @theScrabi 👍

@hannesa2
Copy link
Contributor

Btw, it would be super nice, If I could stream to my Chromecast. I know it's more a feature request

@abelgardep abelgardep mentioned this pull request Feb 26, 2021
Closed
@theScrabi theScrabi changed the title bump exoplayer to version 2.13.1 bump exoplayer to version 2.13.2 Feb 26, 2021
@jesmrec
Copy link
Collaborator

jesmrec commented Mar 1, 2021

A couple of regressions here:

  1. When device rotates in windowed mode, video jumps to 0:00. Before: it continued in the same point.

  2. When video switches to full screen (or to windowed), it jumps to 0:00. Before: it continued in the same point.

CC @theScrabi

@jesmrec jesmrec added the p3-medium Normal priority label Mar 4, 2021
@jesmrec jesmrec added the Sprint label Mar 5, 2021
@jesmrec jesmrec modified the milestones: 2.17-current, 2.18-next Mar 10, 2021
@jesmrec
Copy link
Collaborator

jesmrec commented Mar 12, 2021

Problem is fixed (workarounded), so exoplayer version is correctly bumped

This is approved on my side and looking forward to #3144

@abelgardep abelgardep merged commit 469a9c3 into master Mar 12, 2021
@abelgardep abelgardep deleted the bump_exoplayer branch March 12, 2021 08:29
@jesmrec jesmrec modified the milestones: 2.18-next, 2.17-current Mar 15, 2021
@jesmrec jesmrec removed the Sprint label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

Assignees

@theScrabi theScrabi

Labels
Approved by qa Estimation - 2 (S) p3-medium Normal priority
Projects
None yet
Milestone
2.17
Development

Successfully merging this pull request may close these issues.
4 participants
@theScrabi @abelgardep @hannesa2 @jesmrec