-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed instant upload for photos #110
Conversation
(listened for wrong broadcast action. should be: http://developer.android.com/reference/android/hardware/Camera.html#ACTION_NEW_PICTURE )
That would leave all the users with Android 3.2 or lesser without instant uploads. |
But since in FileDisplayActivity.java Besides, where is com.android.camera.NEW_PICTURE defined? Does not work for me. I'll file a bug report. |
Ok, did not find issue #6 before. It's an "HTC problem". Even though I do not think the NEW_PICTURE action is officially supported and thus ownCloud should not rely on it. |
The app is build with API level 14. The constant android.os.Build.VERSION_CODES.JELLY_BEAN is defined for this level, and replaced for its int value by the builder. The way the constant is used in FileDisplayActivity does not break the code, and does not disable any function for version previous to Android 4.x, unless they are not really available. We test the app in real devices from Android 2.2 onwards. Every Android version from Android 2.2 is supported by the ownCloud app. The constant com.android.camera.NEW_PICTURE is defined in the 'hidden' code in the Android platform. We know it is discouraged to use this kind of code in apps, but it was the fastest way to add an instant upload feature to a broad range of Android devices. We are aware of the problem with HTC devices, and we are not happy that it is still pending to solve. We do our best to fix important problems as long as we are able too, but the development team is small and we must keep focused in top priorities. The solution provided here is not adequate. There is more than a 50% of active Android devices with versions under 4.x, so breaking the instant uploads in all the non-HTC devices in that 50% to add the feature in HTC-4.x devices is a loss, not a gain. If you can contribute with a better solution, we will be extremely happy to accept it. Thanks for your effort. |
We are considering starting to use Owncloud for our users and we use mainly HTC and iPhone. Over half our users use HTC phones. It's a big bummer that auto upload doesn't work, I hope you make this a priority or maybe make a separate install-file available for HTC users with Android 4.x? |
You can solve this problem with a workaround. For example a observer: |
Comments about HTC instant uploads should go to #6 . This issue is closed. |
owncloud app can only detect picture taken from android built-in camera. ps. not only picture. mp4 and 3gp can also be detected and upload to server. |
This issue is closed. Contributions on this topic are welcome in #6, or in any of the other related open issues, most of them tagged with the 'uploads' label. |
Listened for wrong broadcast action. should be:
http://developer.android.com/reference/android/hardware/Camera.html#ACTION_NEW_PICTURE
Requires SDK 14