Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 #468

Closed
wants to merge 19 commits into from
Closed

OAuth2 #468

wants to merge 19 commits into from

Conversation

jesmrec
Copy link
Contributor

@jesmrec jesmrec commented Jul 5, 2017

| 4 | Redirected URL | 1. Set a redirection URL <br>2. Tap on connect. <br>Check both orientations | Fields username and password are shown | |
| 5 | SAML URL | Set an SAML URL (not supported by the app)<br>Check both orientations | Correct error messaege | | |
| 6 | Wrong URL | Set an incorrect URL. <br>Check both orientations | Correct error messaege | | |
| 7 | Wrong Authorizathion endpoint | 1. In customization file, change auth endpoint for a incorrect one<br>2. Enter OAuth2 URL and connect. <br>Check both orientations | Correct error handling | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take into account that all this possible branded option are not going to be brandeable for this round

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know it. Maybe some options will not be brandeable for this approach, but in any case can be set up using customization files.

| 11 | Webview | Enter OAuth2 URL and connect.<br> Check both orientations | Correct webview | | |
| 12 | Correct credentials | 1. Enter OAuth2 URL and connect.<br>2. Enter correct credentials. <br>Check both orientations | 1. Webview is opened<br> 2. Credentials are checked and webview is closed | | |
| 13 | Token expired | Wait until token expires| User is redirected to the webview to enter again the credentials | | |
| 14 | Wrong credentials | 1. Enter OAuth2 URL and connect.<br>2. Enter wrong credentials. <br>Check both orientations | 1. Webview is opened<br> 2. Webview can be closed | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe test case 11 it is already contemplated with this

Copy link
Contributor Author

@jesmrec jesmrec Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TC 11 is a positive TC. TC 14 is a negative one.

| 31 | Several OAuth2 same server | Attach several OAuth2 accounts of the same server on the same device. Check correct expirations. | All correct | | |
| 32 | Several OAuth2 different server | Attach several OAuth2 accounts of different servers on the same device | All correct | | |
| 33 | OAuth2 + basic | Attach an OAuth2 and a basic auth accounts to the same device | All correct | | |s
| 34 | OAuth2 + SAML | Attach an OAuth2 and a SAML auth accounts to the same device | All correct | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will check it as negative TC. Changing expected result...

|**Regression**|||||||
| 35 | Basic Auth server | Open a session in a basic auth server and perform some actions (create folder, update, download, share...) | Success | | |
| 36 | SAML server | Open a session in a SAML server and perform some actions (create folder, update, download, share...) | Success | | |
| 37 | SAML expiration | Open a session in a SAML server and wait until it expires | Redirected to iDP credentials view | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss tests with redirected servers with subfolders in the path

Copy link
Contributor

@nasli nasli Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tests with
-migration the url
-edit account
-upgrade

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will add more test. that was only a first draft.

Copy link
Contributor Author

@jesmrec jesmrec Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade is always checked. This is the most important one.

@nasli nasli mentioned this pull request Jul 11, 2017
110 tasks
@jesmrec jesmrec closed this Aug 2, 2017
@jesmrec jesmrec deleted the oauth2_mobile branch August 2, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants