Move subadmin middleware to app

[DeepDiver1975]

No description provided.

[phil-davis]

should have a standard ownCloud header?

[phil-davis]

Working from a UI POV:

• login as admin, create auser in admin group, buser unpriv
• login as auser, try to go to Users page, works. add a user, put in a group... - works.
• login as buser, try to go to Users page, "access forbidden"

So unpriv users cannot get to the webUI users page.

Is the Users page using some different endpoint underneath? That would need to be check to make sure that an an unpriv user cannot POST transactions to that endpoint "manually".

Somehow we should run core API test features like auth and provisioning-v1 with the user_management app installed and enabled. That will confirm that user/group creation... still "behaves itself" when the user_management app is enabled.

[DeepDiver1975]

Is the Users page using some different endpoint underneath? That would need to be check to make sure that an an unpriv user cannot POST transactions to that endpoint "manually".

the app has own routes to interact with - see the routes.php file

[phil-davis]

As an admin, go to:

http://localhost:8080/index.php/apps/user_management/users

JSON of user data is returned.

Do the same as unpriv user => access forbidden

Good.

[phil-davis]

works

[codecov-io]

Codecov Report

Merging #16 into master will increase coverage by 0.62%.
The diff coverage is 96%.

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     77.22%   77.85%   +0.62%     
- Complexity      176      186      +10     
============================================
  Files            17       19       +2     
  Lines           729      754      +25     
============================================
+ Hits            563      587      +24     
- Misses          166      167       +1

Impacted Files	Coverage Δ	Complexity Δ
lib/SubadminMiddleware.php	100% <100%> (ø)	8 <8> (?)
lib/AppInfo/Application.php	83.33% <83.33%> (ø)	2 <2> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91ab18...85eb94c. Read the comment docs.