-
Notifications
You must be signed in to change notification settings - Fork 335
Updated utils.js to hide saml logo after ldap login. #2169
base: master
Are you sure you want to change the base?
Updated utils.js to hide saml logo after ldap login. #2169
Conversation
any update or review on this PR? if you need more detail i can provide. |
@MorrisJobke any comment ? |
maybe someone from @owncloud/javascript want to have a look :) |
@patelparas you can try to ask people who contributed to this app in the past to review @kazsw @kralizeck @mirekys @adobo @pitbulk @sigmunau |
The code looks fine, but I don't have an environment to test this |
Actually i have developed and tested. and deployed SAML-ADFS in my Production in Feb-2016. it is working fine we didn't find any issue yet...... but again you need to check with latest version...... |
and user_saml app need other changes also like.....
I think we need to rewrite SimplePHPSAML deployment and integration manual step by step. existing one is not sufficient. i know individual contributor will not take interest in this contribution because ADFS-SSO is need for Enterprise Use Case only. |
One question is whether this change would be unacceptable for other SAML user, or compatible ? |
In my organisation we use owncloud-LDAP authentication since long time(2 year). according to time change we need to adopt new technologies and secure method so we recently we decide to enable ADFS-SSO authentication using SAML. we configured it correctly. and it is working fine.
But issue happen when we enable both authentication LDAP + ADFS-SAML simultaneously. because organization some user want to use LDAP some prefer ADFS-SSO. and also to share file with those new user who have never signed-up or sign-in yet. we can't remove LDAP integration because we want to fetch user's list from Active Directory to share files with them.Note: In scenario of ADFS-SSO once user will signup his/her entry created inside oc_users table and then we can share file with them. in this scenario if person use LDAP auth first time to sign-in SAML-login logo don't hide. This one:

it hovers on home screen after login. so i proposed this pull request to solve this issue.