This repository has been archived by the owner on Nov 14, 2018. It is now read-only.
Search lucene refactoring #1624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Who is testing the migration from older versions? |
| @@ -71,27 +119,29 @@ static public function indexFile($path = '', $user = null) { | |||
| $doc = new \Zend_Search_Lucene_Document(); | |||
|
|
|||
| // index content for local files only | |||
| $localFile = $view->getLocalFile($path); | |||
| $localFile = $this->view->getLocalFile($path); | |||
There was a problem hiding this comment.
This does not "index content for local files only"
- uses batch updates because filesystem hooks don't provide file ids - also refactored most of the static access code to new & instance method calls
…d jobs are still in the jobqueue
… prune old index documents in optimize job
This was referenced Jan 31, 2014
This was referenced Feb 11, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DeepDiver1975 @jcfischer @xdmx @icewind1991 this PR introduces a batch approach to indexing. That should solve the problem of storing the path as a job parameter. The new background job also takes care of indexing all unindexed files, not just one.
supersedes #1040
fixes owncloud/core#6479
fixes owncloud/core#6410
Do not yet merge, I intend to also add unit tests.