Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6 #7

Closed
wants to merge 1 commit into from
Closed

Fix #6 #7

wants to merge 1 commit into from

Conversation

nguyentranchung
Copy link

@nguyentranchung nguyentranchung commented Jul 5, 2020

...

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master        #7   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity         2         2           
===========================================
  Files              1         1           
  Lines             12        13    +1     
===========================================
+ Hits              12        13    +1     
Impacted Files Coverage Δ Complexity Δ
src/BladeFontAwesomeServiceProvider.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb9692...55c58c6. Read the comment docs.

@nguyentranchung
Copy link
Author

#6

@driesvints
Copy link
Contributor

This should be closed as #9 provides the correct fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants