-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php8 compatibility + setup github actions #1
base: master
Are you sure you want to change the base?
Conversation
094c538
to
9d66039
Compare
@partikus @marcinlee ping when you have time. |
- restored license
ping @marcinlee @falkenhawk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @marcing for improvements, just left few thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes @marcing !
Since you restored the license file (i have no idea why I added it 7 years ago anyway, I probably used some repo generator) could you remove my email address from it, please 😅
Co-authored-by: partikus <partikus@users.noreply.github.com>
@partikus @falkenhawk @marcinlee committed all the feedback (unless I overlooked something). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Input welcome :)