Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php8 compatibility + setup github actions #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

php8 compatibility + setup github actions #1

wants to merge 8 commits into from

Conversation

marcing
Copy link
Collaborator

@marcing marcing commented Apr 22, 2024

Input welcome :)

@marcing marcing force-pushed the php8 branch 2 times, most recently from 094c538 to 9d66039 Compare April 22, 2024 16:14
@marcing marcing changed the title php 8 compatibility + setup github actions php8 compatibility + setup github actions Apr 22, 2024
@marcing
Copy link
Collaborator Author

marcing commented Apr 29, 2024

@partikus @marcinlee ping when you have time.

@marcing
Copy link
Collaborator Author

marcing commented Jan 8, 2025

  • dropped php-library dependency
  • restored license

ping @marcinlee @falkenhawk

Copy link
Collaborator

@partikus partikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @marcing for improvements, just left few thoughts

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
src/Manifest.php Show resolved Hide resolved
src/Manifest.php Outdated Show resolved Hide resolved
tests/ManifestTest.php Show resolved Hide resolved
Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes @marcing !
Since you restored the license file (i have no idea why I added it 7 years ago anyway, I probably used some repo generator) could you remove my email address from it, please 😅

.gitignore Show resolved Hide resolved
composer.json Show resolved Hide resolved
marcing and others added 2 commits January 9, 2025 18:44
Co-authored-by: partikus <partikus@users.noreply.github.com>
@marcing
Copy link
Collaborator Author

marcing commented Jan 9, 2025

@partikus @falkenhawk @marcinlee committed all the feedback (unless I overlooked something).

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants