Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsonschema): fix job validation #6874

Merged
merged 2 commits into from
Mar 1, 2024
Merged

fix(jsonschema): fix job validation #6874

merged 2 commits into from
Mar 1, 2024

Conversation

rclsilver
Copy link
Contributor

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@rclsilver
fix(jsonschema): fix job validation
7a23ef9 
Signed-off-by: Thomas Bétrancourt <thomas@betrancourt.net>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2024

CDS Report build-cds#20216.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Contrib ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2024

CDS Report build-cds#20216.1 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Contrib ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2024

CDS Report integration-cds#20216.1 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

richardlt
richardlt requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@richardlt richardlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow short ref usage

@rclsilver @richardlt
Update engine/api/v2_jsonschema.go
1f3faba 
Co-authored-by: Richard LT <richard.le.terrier@gmail.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 29, 2024

CDS Report build-cds#20221.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Contrib ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 29, 2024

CDS Report integration-cds#20221.0 ✘

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✘
    • Standalone Tests v2 ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 1, 2024

CDS Report integration-cds#20221.1 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

@rclsilver rclsilver merged commit 829419a into master Mar 1, 2024
3 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@richardlt richardlt deleted the fix-job-validation branch March 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux Awaiting requested review from sguiheux sguiheux is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rclsilver @ovh-cds @yesnault @fsamin @richardlt