fix: bind-mount in dev-specific services #713
Conversation
|
@kdmccormick I have attempted to refactor, and in the process simplify the bind-mounting code. As a consequence I have removed the filter callback de-duplication code we just merged :-/ I understand we could have spared the effort if I had worked on this earlier, but I only became aware of #711 in the past few days... @dagg this PR should resolve your issue with bind-mounting the learning MFE. |
dfe18f5 to
9bddf14
Compare
The -m/--mount option makes it possible to bind-mount volumes at runtime. The volumes are declared in a local/docker-compose.tmp.yml file. The problem with this approach is when we want to bind-mount a volume to a service which is specific to the dev context. For instance: the "learning" service when the MFE plugin is enabled. In such a case, starting the service triggers a call to `docker-compose stop` in the local context. This call fails because the "learning" service does not exist in the local context. Note that this issue only seems to occur with docker-compose v1. To resolve this issue, we create two additional filters for the dev context, which emulate the behaviour of the local context. With this approach, we convert the -m/--mount arguments right after they are parsed. Because they are parsed just once, we can get rid of the de-duplication logic initially introduced with the COMPOSE_CLI_MOUNTS context. Close #711. Close also overhangio/tutor-mfe#57.
9bddf14 to
6b29f22
Compare
|
Hey Kyle, I'm going to be away from keyboard for a few weeks, so I'm going to merge this now. There are a few important bugfixes in the changelog, so I'll create a new release (v14.0.4). If there are important issues in this new release, please let me know by email. If there is a PR with a fix and a new version I should be able to review and merge it. Thanks! |
The -m/--mount option makes it possible to bind-mount volumes at runtime. The
volumes are declared in a local/docker-compose.tmp.yml file. The problem with
this approach is when we want to bind-mount a volume to a service which is
specific to the dev context. For instance: the "learning" service when the MFE
plugin is enabled.
In such a case, starting the service triggers a call to
docker-compose stopin the local context. This call fails because the "learning" service does not
exist in the local context. Note that this issue only seems to occur with
docker-compose v1.
To resolve this issue, we create two additional filters for
the dev context, which emulate the behaviour of the local context. With this approach, we convert the -m/--mount arguments right after they are parsed. Because they are parsed just once, we can get rid of the de-duplication logic initially introduced with the COMPOSE_CLI_MOUNTS context.
Close #711. Close also overhangio/tutor-mfe#57.