Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/qb): removing items from metatable #64

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix(client/qb): removing items from metatable #64

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f94896a
fix(client/qb): removing items from metatable
Manason Feb 8, 2023
ccd48fe
Update qb.lua
Manason Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion client/framework/qb.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ local playerItems = setmetatable({}, {
})

local function setPlayerItems()
playerItems = {}
for k, _ in pairs(playerItems) do
playerItems[k] = nil
end

Copy link
Member

@thelindat thelindat Feb 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table.wipe(playerItems)?

Looking at the file, should just wipe it when triggering QBCore:Client:OnPlayerLoaded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use table.wipe.

I assume you meant QBCore:Player:SetPlayerData
However would we want to do this table wipe if the player is using ox_inventory?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does qb not support logout at all? That's when I'd assume you want to wipe the table.
No need to wipe for ox_inventory unless logout is a thing (which is why I suggested OnPlayerLoaded).

Forgot there's no events for individual data changes (like just items, or a single item) so it's kinda gross in that file.. setting up item count everytime something changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing how this is related to login/logout. The bug we're trying to solve is that when item data changes, say from the user dropping an item, the corresponding entry within playerItems needs to be cleared so that the target code has an updated understanding of the player's items. QBCore:Player:SetPlayerData currently is triggered every time a player's items changes; and since the table is rebuilt within setPlayerItems, the missing step is wiping the table beforehand so that ghost items don't linger around.

for _, item in pairs(playerData.items) do
playerItems[item.name] = item.amount
end
Expand Down