Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxZ is nil on qb-target.lua #106

Closed
yankikucuk opened this issue Sep 7, 2023 · 7 comments
Closed

maxZ is nil on qb-target.lua #106

yankikucuk opened this issue Sep 7, 2023 · 7 comments

Comments

@yankikucuk
Copy link

in line 139 value returned nil with console error.

exportHandler('AddBoxZone', function(name, center, length, width, options, targetoptions)
    local z = center.z

    if not options.useZ then
        z = z + math.abs(options.maxZ - options.minZ) / 2 -- < options.maxZ is nil (tested in qb-core framework after delete qb-target)
        center = vec3(center.x, center.y, z)
    end

    return api.addBoxZone({
        name = name,
        coords = center,
        size = vec3(width, length,
            (options.useZ or not options.maxZ) and center.z or math.abs(options.maxZ - options.minZ)),
        debug = options.debugPoly,
        rotation = options.heading,
        options = convert(targetoptions),
    })
end)

was fixed in #33

any solution for this?

@thelindat
Copy link
Member

any solution for this?

Make it NOT NIL?

@thelindat thelindat closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
@yankikucuk
Copy link
Author

Make it NOT NIL?

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.

If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.

Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.

The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.

good luck.

@thelindat
Copy link
Member

Not my fault that QB can't even manage to use "their" resource correctly. It also isn't my responsibility to provide 100% compatibility for anything, let alone for a framework that steals code and removes copyright notices.

qb-target compatibility is only there because somebody PR'd it. If something doesn't work, then PR a fix, because I frankly could not give any less shits about it.

thelindat added a commit that referenced this issue Sep 16, 2023
"there should not be a compatibility package here" -yankikucuk
@Griefa
Copy link

Griefa commented Sep 16, 2023

Make it NOT NIL?

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.

If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.

Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.

The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.

good luck.

Tell me you're brain dead without telling me you're brain dead

@maalouane
Copy link

Make it NOT NIL?

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.

If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.

Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.

The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.

good luck.

Bruh, you are a drama turkish queen!

@BerkieBb
Copy link
Contributor

Make it NOT NIL?

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.
If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.
Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.
The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.
good luck.

Tell me you're brain dead without telling me you're brain dead

Tell me you crave attention without telling me

@SKITTLE6969
Copy link

Make it NOT NIL?

The scripts I use are codes developed by other people, such as ox_target. and a few lines of code were written in the package (as the folder name suggests) to make it compatible. The fact that there are some problems with the default packages that come with qb-taxijob and similar frameworks must be the duty of the code developed under the name of compatibility here.

If you are considering making the handling situations in each package the responsibility of the user, there should not be a compatibility package here.

Instead of telling me this, what if you wrote a few more lines of code? Because otherwise there is no point in choosing your package. It makes more sense to spend the time writing my own target than I would spend on handling.

The code written does not fully fulfill its purpose. I wrote it for your information. Clean code isn't just about making code that works.

good luck.

are you like brain dead or something bruhhhhhhh? wew there goes the qb-target support CONGRATS buddy

@overextended overextended locked as off-topic and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants