Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): fix lifecycle script progress bar bug #7783

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

dylan-conway
Copy link
Member

What does this PR do?

Always set the progress node name to the most recent lifecycle script. This covers the case where one long lifecycle script is started and installation finishes immediately afterwards.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

tested manually

@Jarred-Sumner Jarred-Sumner merged commit 906f86d into main Dec 22, 2023
18 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/fix-lifecycle-progress branch December 22, 2023 07:46
Copy link
Contributor

@dylan-conway 4 files with test failures on bun-darwin-aarch64:

  • test/cli/install/migration/migrate.test.ts
  • test/cli/run/transpiler-cache.test.ts
  • test/cli/test/bun-test.test.ts
  • test/js/web/timers/setInterval.test.js

View test output

#1d4fe833967a653b453e44971982a2c00bf28e70

Copy link
Contributor

@dylan-conway 4 files with test failures on linux-x64:

  • test/cli/test/bun-test.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/web/fetch/fetch-gzip.test.ts
  • test/js/web/workers/worker.test.ts

View test output

#1d4fe833967a653b453e44971982a2c00bf28e70

Copy link
Contributor

@dylan-conway 4 files with test failures on linux-x64-baseline:

  • test/cli/test/bun-test.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/web/fetch/fetch-gzip.test.ts
  • test/js/web/workers/worker.test.ts

View test output

#1d4fe833967a653b453e44971982a2c00bf28e70

Copy link
Contributor

@dylan-conway 6 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/prompts/prompts.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/fetch/fetch.test.ts

View test output

#1d4fe833967a653b453e44971982a2c00bf28e70

Copy link
Contributor

@dylan-conway 5 files with test failures on bun-darwin-x64:

  • test/cli/test/bun-test.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/fetch/fetch.test.ts

View test output

#1d4fe833967a653b453e44971982a2c00bf28e70

ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants