Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7324 #7330

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fixes #7324 #7330

merged 1 commit into from
Nov 27, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Fixes #7324

Adds override as a TypeScript accessibility modifier. We must've forgotten this.

How did you verify your code works?

There is a regression test

Copy link
Contributor

github-actions bot commented Nov 27, 2023

@Jarred-Sumner 6 files with test failures on bun-darwin-aarch64:

  • test/bundler/esbuild/extra.test.ts
  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/glob/scan.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/util/which.test.ts

View test output

#e40ede53aba207801fd15d93b18cb91906abcbdd

Copy link
Contributor

@Jarred-Sumner 6 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#e40ede53aba207801fd15d93b18cb91906abcbdd

Copy link
Contributor

@Jarred-Sumner 10 files with test failures on bun-darwin-x64:

  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/js/bun/http/bun-server.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/prompts/prompts.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#e40ede53aba207801fd15d93b18cb91906abcbdd

@dylan-conway dylan-conway merged commit 6ee42f7 into main Nov 27, 2023
20 of 28 checks passed
@dylan-conway dylan-conway deleted the jarred/fix-7324 branch November 27, 2023 20:12
cirospaciari pushed a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bun is unable to parse override in constructor parameters
2 participants