fix(blob): Add the current offset to the new blob slice #6259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Close: #6252
offset
is overwritten byrelativeStart
, causingblob.slice().slice()
to always use the parameters from the lastslice
call. This Add the currentoffset
to the new blob slice.bun/src/bun.js/webcore/blob.zig
Lines 3010 to 3012 in 47651f3
How did you verify your code works?
I wrote automated tests
zig fmt
on the changed files