-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement test.todo
#2961
Implement test.todo
#2961
Conversation
test_files.len, | ||
}); | ||
const total_tests = reporter.summary.fail + reporter.summary.pass + reporter.summary.skip + reporter.summary.todo; | ||
Output.prettyError("Ran {d} tests across {d} files. <d>{d} total<r> ", .{ reporter.summary.fail + reporter.summary.pass, test_files.len, total_tests }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added total count
this looks great. i love how nicely it formats in my terminal. Can you add a feature to this that isn't specifically defined by jest? test.todo("test", () => {
apiThatIsBrokenOrNotImplemented()
}) This would have the semantics of "TODO: implement the code we are testing" instead of "TODO: implement this test". and it will run this test and if it fails, it logs a todo notice like we already have. but if the test passes, it logs a test fail informing that the test has been implemented. so it's kind of like this specific feature is something I've wanted for a while to use for our bundler tests, as we have many failing and skipped tests, when we are aware of their failure, but if any of them start passing, we want to know so we can add them to the list of expected passes. |
This is the logs for different cases of |
looks awesome. i love it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thank you
Progress for #1825