fix: check if we are crashing before exiting gracefully #12865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave, your commit has failing tests :( 🪟💻 2 failing tests Windows x64 baseline
🪟💻 2 failing tests Windows x64
|
paperclover
added a commit
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While working on #12864 I hit a hilarious edge case:
We started crashing, but since the crash was on a bundler thread, the main thread was able to successfully terminate.
This makes our exit function check if we are terminating (one atomic load) and will instead sleep forever.
Additionally, I realized that sometimes bun would crash on a second thread while the first is crashing. This worked fine before with panics, but not segfaults.
This also removes
Global.panicin favor ofOutput.panic