Satp version 1 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te the asset status
implemented the lock assertion method Added the lock-assertion-receipt and lock-assertion-broadcast methods Added the request to the driver to lock an asset corrected some variable names Added the endpoints corresponding to the steps 3.1 to 3.9 Implemented the step 2.1B so that the driver call the gateway to update the asset status Implemented the status check functionality required for 2.1B, 3.2B, 3.4B, and 3.6B First iteration of switching to real driver (fabric) Added the required functions to call back the gateway after the asset is locked. initial commit Initial commit for create-asset, extinguish, and assign-asset Added the resources required to assign an asset uncommented the perform lock part corrected compile error due to merging issue
sandeepnRES
reviewed
Sep 21, 2023
| @@ -0,0 +1,714 @@ | |||
| /* | |||
There was a problem hiding this comment.
This and few other files that are copied from fabric-cli, these were good for you to get easily implement functions in driver, but when we want to merge it to main, can you filter out what is needed and what is not and add those only? And see if similar function is already available in other TS files in fabric-driver (because mostly it would), and use those if possible.
Its not urgent, it can be done at the very last stage also when PR is ready to be merged.
|
Merging this branch to satp branch where all changes related to satp implementation have been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first working implementation of satp. I squashed all previous commits into one. I am not sure why the corresponding commits still show up. The next step is to add the resources to extinguish an asset and to remove the hard coded values in fabric driver.