feat: Sapt stage 1 #1
Conversation
|
I've added an initial skeleton code to implement the SATP. This includes creating the relevant proto files, the requires client and services provided by the gateway. The focus was on the interactions 1.3, 1.4, 2.2 and 2.4. This code review is to ensure the draft code is readable and maintainable so that similar approach will be taken to implement the remaining functions. |
| @@ -0,0 +1,1044 @@ | |||
| # Copyright IBM Corp. All Rights Reserved. | |||
There was a problem hiding this comment.
This file is for what purpose?
There was a problem hiding this comment.
In this file I thought it is better to have the test done between two fabric networks only as a starting point.
| @@ -0,0 +1,367 @@ | |||
| # Copyright IBM Corp. All Rights Reserved. | |||
There was a problem hiding this comment.
If you want to use this file for satp_test, may be call it test_weaver-satp.yaml
There was a problem hiding this comment.
So maybe test_weaver-fabric-fabric-satp.yaml
weaver/core/relay/Cargo.toml
Outdated
| [[bin]] | ||
| name = "client-tls" | ||
| path = "src/client_tls.rs" | ||
|
|
||
| [[bin]] |
There was a problem hiding this comment.
this is duplicate entry as line 15-17 also points to same file src/satp_client.rs
| let request_id = transfer_commence_request.session_id.to_string(); | ||
| // TODO refactor | ||
| let request_logged: Result<Option<sled::IVec>, crate::error::Error> = | ||
| log_request_in_local_sapt_db(&request_id, &network_asset_transfer, conf.clone()); |
There was a problem hiding this comment.
sapt typo, also check other places too.
No description provided.