Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default parameter from null to empty array in getSettings… #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NadsonKT
Copy link

This pull request includes changes to the NovaSettings functionality to ensure that the getSettings method handles default values more consistently. The most important changes include modifying the method signatures in several files to use empty arrays as default parameters instead of null.

Consistency improvements to getSettings method:

  • src/NovaSettings.php: Changed the getSettings method to use an empty array as the default value for settingKeys instead of null.
  • src/NovaSettingsStore.php: Updated the getSettings method to use an empty array as the default value for settingKeys instead of null.
  • src/helpers.php: Modified the nova_get_settings function to use an empty array as the default value for settingKeys instead of null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant