Fix some problems with importing OBJ and FBX #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Preserve vertex order.
- When merging data with an existing shape, give option to update normals.
- Correctly handles faces with more than 4 vertices.
- Handle OBJ comments correctly.
- Clean up a few things in ObjFile.{h,cpp}.
- Don't duplicate vertices when normals or uvs are duplicated in the file.
- Handle negative OBJ vertex/texture/normal indices correctly.
-Polygons with more than three vertices were not handled. -Ask user if they want to update normals when merging.
This was
linked to
issues
Mar 9, 2022
I misread the code and fixed something that wasn't broken.
- Made FBX import split vertices with differing UVs or normals. - For OBJ/FBX import with a merge into an existing shape, only ask if the user wants to update UVs/normals if the file has them. - Swap x,y,z around for normals on FBX import/export to match what it does for vertex coordinates.
ousnius
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For importing OBJ:
For importing FBX:
For exporting FBX: