O/add content field to nftinterface #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainnash
reviewed
May 20, 2022
| }; | ||
|
|
||
| if (asset.contentURL) { |
There was a problem hiding this comment.
are we duplicating the content fields here?
iainnash
reviewed
May 20, 2022
|
sounds good
…On Mon, May 23, 2022 at 20:02 Oleg Akbarov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/types/NFTInterface.ts
<#121 (comment)>:
> image?: MediaObject;
large?: MediaObject;
poster?: MediaObject;
+ thumbnail?: MediaObject;
+ // backwards compatibility
content?: MediaObject;
so idea is to retain backwards compatibility
i was thinking about going back to it when covering the whole thing with
tests, wdyt?
—
Reply to this email directly, view it on GitHub
<#121 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGMCOCGVIKRP3WN34IEC6DVLQMA7ANCNFSM5WN55FFQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
iainnash
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.